From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31027 invoked by alias); 10 Sep 2014 15:04:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31018 invoked by uid 89); 10 Sep 2014 15:04:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1blp0181.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (207.46.163.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 10 Sep 2014 15:04:22 +0000 Received: from BN1BFFO11FD016.protection.gbl (10.58.144.33) by BN1BFFO11HUB059.protection.gbl (10.58.144.206) with Microsoft SMTP Server (TLS) id 15.0.1019.14; Wed, 10 Sep 2014 15:04:18 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BN1BFFO11FD016.mail.protection.outlook.com (10.58.144.79) with Microsoft SMTP Server (TLS) id 15.0.1019.14 via Frontend Transport; Wed, 10 Sep 2014 15:04:18 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1XRjN3-000645-MJ; Wed, 10 Sep 2014 07:59:45 -0700 From: Ajit Kumar Agarwal To: Joel Brobecker CC: Michael Eager , "gdb-patches@sourceware.org" , Vinod Kathail , "Vidhumouli Hunsigida" , Nagaraju Mekala Subject: RE: [Patch, microblaze]: Port of Linux gdbserver Date: Wed, 10 Sep 2014 15:04:00 -0000 References: <2570e3c7-f55b-45cd-aa6e-7f4fa145f32a@BN1BFFO11FD002.protection.gbl> <541052B5.5080503@eagercon.com> <20140910134606.GO28404@adacore.com> <050c6461-c35c-441d-9b63-7636d9164e2e@BL2FFO11FD048.protection.gbl> <20140910144313.GP28404@adacore.com> In-Reply-To: <20140910144313.GP28404@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <40bc6b14-7a94-4118-9e88-c76dc03a0a67@BN1BFFO11FD016.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(6009001)(438002)(13464003)(199003)(189002)(377454003)(377424004)(51704005)(54356999)(31696002)(83322001)(92566001)(1496007)(74316001)(74662001)(74502001)(99396002)(50986999)(46102001)(85852003)(19580395003)(76176999)(97756001)(46406003)(44976005)(23726002)(2656002)(76482001)(92726001)(87936001)(86362001)(19580405001)(6806004)(50466002)(31966008)(81542001)(83072002)(20776003)(107046002)(106116001)(64706001)(95666004)(106466001)(77096002)(4396001)(53416004)(70736001)(79102001)(80022001)(81342001)(110136001)(85306004)(33646002)(77982001)(104016003)(90102001)(21056001)(47776003)(93886004)(107986001)(23106004);DIR:OUT;SFP:;SCL:1;SRVR:BN1BFFO11HUB059;H:xsj-pvapsmtpgw01;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:; X-Forefront-PRVS: 033054F29A Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-OriginatorOrg: xilinx.com X-SW-Source: 2014-09/txt/msg00318.txt.bz2 -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com]=20 Sent: Wednesday, September 10, 2014 8:13 PM To: Ajit Kumar Agarwal Cc: Michael Eager; gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hu= nsigida; Nagaraju Mekala Subject: Re: [Patch, microblaze]: Port of Linux gdbserver [with my patch-champion hat] I can't review the gdbserver Changes, but I can look at the rest. > ChangeLog: > 2014-10-09 Ajit Agarwal >=20 > * configure.host (microblaze): New. > (microblaze*-*-linux*): New. > * configure.tgt (build_gdbserver): New Definition. > * gdbserver/Makefile.in (microblaze-linux.c): New target. > * gdbserver/configure.srv (microblaze*-*-linux*): New target. > * gdbserver/linux-microblaze-low.c: New file. Sorry Ajit. I should have seen this in the previous iteration, but there ar= e a couple more nits in the ChangeLog entry that you'll need to fix. >>First, gdb and gdb/gdbserver have distinct ChangeLog files, so you'll nee= d to have 2 ChangeLog entries if you touch both areas at the same time. Th= is >>means that the filenames in gdbserver should not be prefixed with "gdb= server/" in your ChangeLog entry. >>Also, change "ChangeLog:" to "gdb/ChangeLog:" and "gdbserver/ChangeLog:". >>Please exclude the configure.host change. This looks unrelated. I will incorporate this. > diff --git a/gdb/configure.tgt b/gdb/configure.tgt index=20 > 01311b2..e4894da 100644 > --- a/gdb/configure.tgt > +++ b/gdb/configure.tgt > @@ -343,6 +343,7 @@ microblaze*-linux-*|microblaze*-*-linux*) > gdb_target_obs=3D"microblaze-tdep.o microblaze-linux-tdep.o microblaze-= rom.o \ > monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o" > gdb_sim=3D../sim/microblaze/libsim.a > + build_gdbserver=3Dyes > ;; > microblaze*-*-*) > # Target: Xilinx MicroBlaze running standalone diff --git=20 > a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index=20 > 1447e61..b2a01f5 100644 > --- a/gdb/gdbserver/Makefile.in > +++ b/gdb/gdbserver/Makefile.in > @@ -153,6 +153,7 @@ SFILES=3D $(srcdir)/gdbreplay.c $(srcdir)/inferiors.c= $(srcdir)/dll.c \ > $(srcdir)/linux-ia64-low.c $(srcdir)/linux-low.c \ > $(srcdir)/linux-m32r-low.c \ > $(srcdir)/linux-m68k-low.c $(srcdir)/linux-mips-low.c \ > + $(srcdir)/linux-microblaze-low.c \ > $(srcdir)/linux-nios2-low.c \ > $(srcdir)/linux-ppc-low.c \ > $(srcdir)/linux-s390-low.c \ > @@ -364,6 +365,7 @@ clean: > rm -f amd64-mpx.c amd64-mpx-linux.c > rm -f amd64-avx512.c amd64-avx512-linux.c > rm -f i386-mmx.c i386-mmx-linux.c > + rm -f microblaze-linux.c > rm -f x32.c x32-linux.c > rm -f x32-avx.c x32-avx-linux.c > rm -f x32-avx512.c x32-avx512-linux.c >>There are indentation errors in the two hunks above. Use tabs. I will do this. > @@ -634,6 +636,8 @@ mips64-linux.c : $(srcdir)/../regformats/mips64-linux= .dat $(regdat_sh) > $(SHELL) $(regdat_sh) $(srcdir)/../regformats/mips64-linux.dat=20 > mips64-linux.c mips64-dsp-linux.c : $(srcdir)/../regformats/mips64-dsp-l= inux.dat $(regdat_sh) > $(SHELL) $(regdat_sh) $(srcdir)/../regformats/mips64-dsp-linux.dat=20 > mips64-dsp-linux.c > +microblaze-linux.c : $(srcdir)/../regformats/microblaze-with-stack-prote= ct.dat $(regdat_sh) > + $(SHELL) $(regdat_sh)=20 > +$(srcdir)/../regformats/microblaze-with-stack-protect.dat=20=20 > +microblaze-linux.c > nios2-linux.c : $(srcdir)/../regformats/nios2-linux.dat $(regdat_sh) > $(SHELL) $(regdat_sh) $(srcdir)/../regformats/nios2-linux.dat=20 > nios2-linux.c powerpc-32.c :=20 > $(srcdir)/../regformats/rs6000/powerpc-32.dat $(regdat_sh) diff --git=20 > a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv index=20 > 679fc9f..16e44ee 100644 > --- a/gdb/gdbserver/configure.srv > +++ b/gdb/gdbserver/configure.srv > @@ -194,6 +194,12 @@ case "${target}" in > srv_linux_usrregs=3Dyes > srv_linux_thread_db=3Dyes > ;; > + microblaze*-*-linux*) srv_regobj=3Dmicroblaze-linux.o > + srv_tgtobj=3D"$srv_linux_obj linux-microblaze-lo= w.o" > + srv_linux_usrregs=3Dyes > + srv_linux_regsets=3Dyes > + srv_linux_thread_db=3Dyes > + ;; > nios2*-*-linux*) srv_regobj=3D"nios2-linux.o" > srv_tgtobj=3D"$srv_linux_obj linux-nios2-low.o" > srv_xmlfiles=3D"nios2-linux.xml" > diff --git a/gdb/gdbserver/linux-microblaze-low.c=20 > b/gdb/gdbserver/linux-microblaze-low.c > new file mode 100644 > index 0000000..b86b4f5 > --- /dev/null > +++ b/gdb/gdbserver/linux-microblaze-low.c >>It looks to me like you have many many trailing spaces in the file you ar= e submitting. Please strip them. >>Some lines are too long, also. Joel: I have splitted the lines where it exceeds 80 Cols. I have removed tr= ailing spaces as much as I can. Could=20 You please give one example of the trailing space which I have not removed. Thanks & Regards Ajit -- Joel