From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 1EE8A3858D28 for ; Wed, 25 Jan 2023 10:54:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1EE8A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso975714wmq.5 for ; Wed, 25 Jan 2023 02:54:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y1zFvmSmRQ/1rslXaDXuII/BNHBS9FPIF8s2BmFqrCw=; b=CdVyG8Vuo7eJgchw28eSgOaLqX1a5DjRNxd8JdaVx2aU56ZIUvxjMfjqNRNfb9gKSJ XqUdFp/HfNM4JJDs85QBuqDOYxeRXfUm+OzsVOlPAjPjI+aypTn83qlSmzvgBMD557Fs UWr2airqCmX6otNiapwg9i7OJ18o+63wcip0hT436lKnyNtGckkKIbtpqCbZa5WVbFFB sLW08N3EfGUVYmAJA5Qblf0tb2v3xC9S2VnKTQum4p2XfvTXS75vCgJkuSyOLPVnuCqQ 5ZaKPiR6t+vqe3LKgKX1CtJ8GjV0UAL6DbhgzhGwj/LHtea4uIcBUx3XYrncOQrhlFtO 0JdA== X-Gm-Message-State: AFqh2koDfPbU+Lu0FIGy8L9TJjb2OK2qf/tnevDHtGWyoh2nVh9kohjZ 8E5B8hJ7HAdEv2uLnEqdX8AFoKWdKyaTXQ== X-Google-Smtp-Source: AMrXdXugcC6QOZIR8uTgBg5owhd1A/WxQYlGbbr4X9l6NilTO6NYl8sWQkP+HNlyFAIJUE6KFUQNkg== X-Received: by 2002:a7b:c5cb:0:b0:3da:fac4:7da3 with SMTP id n11-20020a7bc5cb000000b003dafac47da3mr30964640wmk.36.1674644073267; Wed, 25 Jan 2023 02:54:33 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id d24-20020a05600c4c1800b003db0cab0844sm1414457wmp.40.2023.01.25.02.54.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 02:54:32 -0800 (PST) Subject: Re: [PATCH v2 1/9] Convert skip_altivec_tests to allow form To: Tom Tromey , gdb-patches@sourceware.org References: <20230124230243.2471957-1-tom@tromey.com> <20230124230243.2471957-2-tom@tromey.com> From: Pedro Alves Message-ID: <40f9ff3f-ab5e-86e4-806f-8acda3767bb5@palves.net> Date: Wed, 25 Jan 2023 10:54:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230124230243.2471957-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-24 11:02 p.m., Tom Tromey wrote: > -if {![istarget "powerpc*"] || [skip_altivec_tests]} { > +require allow_altivec_tests > +if {![istarget "powerpc*"]} { > verbose "Skipping altivec abi tests." > return > } I noticed that this transformation changed one thing -- we'd now run allow_altivec_tests, and hence the compilation tests that allow_altivec_tests does, on all targets, while before we wouldn't, since the istarget check used to be before the skip_altivec_tests check. Functionally, it's the same, even though it slows down testing a tiny bit for non-powerpc targets. In the end, you'd now added the patch that removes this istarget check in the last patch of the series, so it's good as is, no need to change anything here. I went to look whether the skip_power_isa_3_1_tests and skip_vsx_tests patches (patches #3 and #4) were likewise affected (as those are similar and could also have the istarget check pushed down), but in those you've kept the order: -if {![istarget "powerpc*-*-linux*"] || [skip_vsx_tests]} { +if {![istarget "powerpc*-*-linux*"]} { verbose "Skipping PowerPC test for corefiles with VSX registers." return } +require allow_vsx_tests ... so we're all good. The whole series looks good to me.