Re: [PATCH v5 0/4] gdb: add gdb_attach to fix failed testcases

[Pedro Alves <pedro@palves.net>]

On 2022-03-22 06:41, Tiezhu Yang wrote:
> Please review this v5 patchset, thank you.

Looks fine to me.

BTW, I tried setting ptrace_scope=1 and then running gdb.base/attach.exp, as probably the main attach testcase, and it
unsurprisingly FAILs:

 $ echo 1 | sudo tee /proc/sys/kernel/yama/ptrace_scope
 $ make check TESTS="gdb.base/attach.exp"
 ...
 Running /home/pedro/gdb/build/gdb/testsuite/../../../src/gdb/testsuite/gdb.base/attach.exp ...
 FAIL: gdb.base/attach.exp: do_attach_tests: attach1, after setting file
 FAIL: gdb.base/attach.exp: do_attach_tests: attach1 detach (the program is no longer running)
 FAIL: gdb.base/attach.exp: do_attach_tests: attach2, with no file
 FAIL: gdb.base/attach.exp: do_attach_tests: after attach2, set should_exit
 FAIL: gdb.base/attach.exp: do_attach_tests: continue to breakpoint: postloop (the program is no longer running)
 FAIL: gdb.base/attach.exp: do_attach_tests: continue until exit at after attach2, exit (the program is no longer running)
 FAIL: gdb.base/attach.exp: do_attach_tests: attach when process' a.out not in cwd
 ...


The curious thing is that the first FAIL is already a gdb_test_multiple:

    set test "attach1, after setting file"
    gdb_test_multiple "attach $testpid" "$test" {
	-re "Attaching to program.*`?$escapedbinfile'?, process $testpid.*main.*at .*$srcfile:.*$gdb_prompt $" {
	    pass "$test"
	}
	-re "Attaching to program.*`?$escapedbinfile\.exe'?, process $testpid.*\[Switching to thread $testpid\..*\].*$gdb_prompt $" {
	    # Response expected on Cygwin
	    pass "$test"
	}
    }

So I really think we will want to do the idea at 
<https://sourceware.org/pipermail/gdb-patches/2022-March/186795.html>.  But it can be
done after your patches are in.  I'm fine with you merging what you have as is.