From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6B2A23858D3C for ; Fri, 22 Dec 2023 16:56:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B2A23858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B2A23858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703264189; cv=none; b=BWANDT26rkoFeA3AcrALm2dDxtGUQ+XM7gktGS5lPwz46C7tEhKe1PELlY8zFXhJqEgeJKAEN+B/ln6F8ZE1pCPK7TuYbSHMmpqqLkBPvgTW9xyYmGCc2R/v7VAFP+eNtxJ2PLPKg13V1Lgcuov1QiNTRVO0E0v2xoOahJI52Do= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703264189; c=relaxed/simple; bh=FYrhlnzLkH8FiY0JNgNSZipQxAhvavA1FMXuqN+VoYA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Lb62HiywahO72wWf8N2/SS6N0YnXHp+pj4XNLW6r6Fs7dnIgd0s3AQfEZgFDn25arle/umr7fvbc1HoW1ffFP06QV6bd3bOjoVRpELnx2XLZLBVlUH6ZdnCWyyA0bTTg5FjB5mJB809xk+hx6VXQ5E09khJSmcS1NvlAsKjnqMY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703264187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FmTmrVCuTgRw5Luc5NDVNGid1BQSP2sf0p+JFlmXioQ=; b=DQfH9O/j1y16afR9FKgq6+5t2O/cCTcUo9PrlCCDK5W03ZawwG4VKtLmMlhkjO55/cxI9D Qecivbryi0Rca+tbuOiHBVvUbfMdSAM89lxdEBVhZaATkVk5j0i05mmjDhynhF6P2m/6tN 10BcADd5kfQX+60N29m3ZeQo7eylo8U= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-4pw-N74QMtC6lITpXhjxbA-1; Fri, 22 Dec 2023 11:56:23 -0500 X-MC-Unique: 4pw-N74QMtC6lITpXhjxbA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2cc7944cf8eso16958921fa.3 for ; Fri, 22 Dec 2023 08:56:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703264181; x=1703868981; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FmTmrVCuTgRw5Luc5NDVNGid1BQSP2sf0p+JFlmXioQ=; b=qPq8eEI2UjnGt8w6P3SM7xOFHSssLW0v8o9onVjIAssYlccNRxIGq3jWDIaZxFEwCo YuFKSsLzc/FdofSrptAyWfi8BtiF34smrCpJT+tbq6H411RR2a0eQ+w6lkiv1WW/Kjp0 04X1K/hPwmjMEVhvus4aKxoApSbfiaee+FD/VeU5yYiPEdu4TpZDBNZMpv89z+QRlS2x JWILznkH+A0vyK9QXD9L2xNoESTzP+/puLCn6WxZQcHJwXi10Ea6HSIgEIv+6xKNEY6T NXV7IXRiMlbIiD+bxgEzEeVD1b+cFPFQjlc1RY1udEEwdTNeHg6K/7Z76dqLWuMm1TXK 2B0A== X-Gm-Message-State: AOJu0YxhS4E7fjQXw5B+q0TaPccgGbDSCEQBrCaJuJCKqoS8l1c+jHPV T2l42Xk7yxbz3MSzKeXFB+SmRWmSa+64i2FSDSGKwkNkpR0U4QQJX95qAoGVMhuSRA7CM9NWD3H ujVjOVmH0pG3aDMWkiqM+GqLPbZhTkSvSo6q/QQ== X-Received: by 2002:a2e:9dd2:0:b0:2cc:61df:1cf4 with SMTP id x18-20020a2e9dd2000000b002cc61df1cf4mr404936ljj.61.1703264180880; Fri, 22 Dec 2023 08:56:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjKaeZW3MGJk2baSpxJwO61BiGtiZOpT32J9cnQ+mOtajXX8HZrX0jHZmehC7BrCbcya87Xg== X-Received: by 2002:a2e:9dd2:0:b0:2cc:61df:1cf4 with SMTP id x18-20020a2e9dd2000000b002cc61df1cf4mr404933ljj.61.1703264180565; Fri, 22 Dec 2023 08:56:20 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id k3-20020aa7c043000000b00552eb1b1ed7sm2759056edo.16.2023.12.22.08.56.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Dec 2023 08:56:20 -0800 (PST) Message-ID: <414c1389-9b4c-b62d-6a2c-9906878c5569@redhat.com> Date: Fri, 22 Dec 2023 17:56:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] gdb/dwarf2: Add support for DW_LNS_set_epilogue_begin in line-table To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231221102925.377720-1-blarsen@redhat.com> <87sf3u19ih.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87sf3u19ih.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/12/2023 17:34, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> This commit adds a mechanism for GDB to detect the linetable opcode > Guinevere> DW_LNS_set_epilogue_begin. This opcode is set by compilers to indicate > Guinevere> that a certain instruction marks the point where the frame is destroyed. > > Thanks for doing this. It looks good to me. > Approved-By: Tom Tromey > > Tom > Thanks for approving! I will follow Carl Love's rule of not pushing something right before leaving for vacation, and only do it once I'm back from the holidays, though :) -- Cheers, Guinevere Larsen She/Her/Hers