From: Simon Marchi <simark@simark.ca>
To: Kevin Buettner <kevinb@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb: remove SYMBOL_*_OPS macros
Date: Fri, 19 Jan 2024 22:15:49 -0500 [thread overview]
Message-ID: <418e1e90-902e-4915-a664-4d3e1227c950@simark.ca> (raw)
In-Reply-To: <20240119154528.4a023ea0@f39-zbm-amd>
On 2024-01-19 17:45, Kevin Buettner wrote:
> On Fri, 19 Jan 2024 15:32:32 -0500
> Simon Marchi <simon.marchi@efficios.com> wrote:
>
>> New in v2:
>>
>> - remove one use of auto in findvar.c
>> - fix formatting in frame.c
>>
>> Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in
>> favor of methods on struct symbol. More changes could be done here to
>> improve the design and make things safer, but I just wanted to do a
>> straightforward change to remove the macros for now.
>
> LGTM.
>
> Reviewed-by: Kevin Buettner <kevinb@redhat.com>
>
Thanks, pushed.
Simon
prev parent reply other threads:[~2024-01-20 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 20:32 Simon Marchi
2024-01-19 22:45 ` Kevin Buettner
2024-01-20 3:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418e1e90-902e-4915-a664-4d3e1227c950@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).