From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 08EBD3854161 for ; Mon, 31 Oct 2022 12:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08EBD3854161 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667220381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=esxRpbUEm2Nsivm+hcol/7oc43RAjhL4BhsJcPm0XPY=; b=gWxgk4gKJVAGXbNm3dxklv939Rf5/R7tUOeDyWdHqR4MW9BYDLi2/7zlg21eLrp/dnTSI3 NkZwM+RY9rW+xyn/DkX8q/sEn/CsprHRJ/VMbcGKExiWk9do/FhRixgoHGrIJyZdUj73JE hjaLuVJc0GG7KaIjkmr83w8aKbB3NgY= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-648-zJxCUBT8PsumtBBXvVp8vA-1; Mon, 31 Oct 2022 08:46:18 -0400 X-MC-Unique: zJxCUBT8PsumtBBXvVp8vA-1 Received: by mail-qk1-f199.google.com with SMTP id x22-20020a05620a259600b006b552a69231so9276587qko.18 for ; Mon, 31 Oct 2022 05:46:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=esxRpbUEm2Nsivm+hcol/7oc43RAjhL4BhsJcPm0XPY=; b=ESmazjXk49onP9tw/fJig0yKhL5vE13hMzMQ+vUTDpzftobbMonTVx/jhhjUo9WvIC 8O5rvFHP81VjTBges5f4r+O0jBQcROqBUqI+DROrXW9TFd7LuiT0sNOXhJ7c5hHRtc2a gNXz6ahVvxOhT3duxvpJsAzFCySc2obkRSxx3gHp7+mvPuuNQvLv4gdC3Z5PVuiq9sND jHYM6RBN/wodQ++MdZ181UyAN1Cnu4HuDyJKOFW/qN3EOr08bwPvKoF+kGFdgCSxXNkU v2ZgHI7CBCbzNeeMLmRDvhcpbibkIm9bbP1ZmEsZotB0XbIY4qtMyHKd04EST7golCW3 tGvQ== X-Gm-Message-State: ACrzQf3MmTKFhIO2+kbP2RgQKhlOtKqpU7m8eyLrYVU1pjEMvm3JSVjB SEj2Dk4Jn4rpo6PLZogLbstpexMaFMrSu3qkfIhGEsmmgPn8u+3+ZOE1Wc5arPOZiwEZXTswYk/ YuNe3vN74TtvfmziIbExWhw== X-Received: by 2002:a05:622a:2286:b0:3a5:1ab4:77fb with SMTP id ay6-20020a05622a228600b003a51ab477fbmr7917948qtb.85.1667220376912; Mon, 31 Oct 2022 05:46:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7QOJeS10Ity6qgMdm+k2jEOUiHCq8CCrUnFvIIC078sHQBHXovr8OJe1i+F1sRuD62BYORKw== X-Received: by 2002:a05:622a:2286:b0:3a5:1ab4:77fb with SMTP id ay6-20020a05622a228600b003a51ab477fbmr7917934qtb.85.1667220376727; Mon, 31 Oct 2022 05:46:16 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id y24-20020a37f618000000b006cf19068261sm4511344qkj.116.2022.10.31.05.46.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 05:46:16 -0700 (PDT) Message-ID: <41cd4a85-6a3c-ccdc-e7dc-73f41822fb36@redhat.com> Date: Mon, 31 Oct 2022 13:46:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 09/11] gdb/testsuite: fix gdb.cp/converts.exp to run with clang To: Andrew Burgess , gdb-patches@sourceware.org References: <20221004170747.154307-1-blarsen@redhat.com> <20221004170747.154307-11-blarsen@redhat.com> <87mt9i60o3.fsf@redhat.com> From: Bruno Larsen In-Reply-To: <87mt9i60o3.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26/10/2022 17:54, Andrew Burgess wrote: > Bruno Larsen via Gdb-patches writes: > >> Clang attempts to minimize the size of the debug-info by not adding >> complete information about types that aren't constructed in a given >> file. In specific, this meant that there was minimal information about > s/In specific/Specifically/. > >> class B in the test gdb.cp/converts.exp. To fix this, we just need to >> construct any object of type B in that file. >> --- >> gdb/testsuite/gdb.cp/converts.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.cp/converts.cc b/gdb/testsuite/gdb.cp/converts.cc >> index ecf806481fd..1224581a879 100644 >> --- a/gdb/testsuite/gdb.cp/converts.cc >> +++ b/gdb/testsuite/gdb.cp/converts.cc >> @@ -55,7 +55,7 @@ int main() >> >> char av = 'a'; >> char *a = &av; // pointer to.. >> - B *bp; >> + B *bp = new B(); > LGTM. Thanks! I pushed with the change to the commit message. Cheers, Bruno > > Thanks, > Andrew > >> foo1_1 (a); // ..pointer >> foo1_2 (a); // ..array >> foo1_3 ((int*)a); // ..pointer of wrong type >> -- >> 2.37.3