From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove tailing newlines from index_cache_debug calls
Date: Mon, 7 Feb 2022 19:10:55 -0500 [thread overview]
Message-ID: <41ecbc94-012e-e765-e37f-3fd923276218@polymtl.ca> (raw)
In-Reply-To: <20220207204547.3364272-1-aburgess@redhat.com>
On 2022-02-07 15:45, Andrew Burgess via Gdb-patches wrote:
> I noticed that most of the calls to index_cache_debug include a
> trailing newline. As the new debug mechanism already adds a newline,
> that means all of these debug calls result in a blank line being
> printed, which I think is a mistake.
>
> Remove all the trailing newlines.
>
> I also reformatted one of the index_cache_debug where a string will
> now fit onto a single line.
>
> Unless 'set debug index-cache on' is used, there should be no visible
> change in output after this commit.
Thanks for doing this, it's surely an oversight on my part. I think it's an obvious change.
Simon
next prev parent reply other threads:[~2022-02-08 0:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 20:45 Andrew Burgess
2022-02-08 0:10 ` Simon Marchi [this message]
2022-02-08 9:23 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ecbc94-012e-e765-e37f-3fd923276218@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).