From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 75000388A003 for ; Thu, 2 Apr 2020 15:14:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 75000388A003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0CA39AAB8; Thu, 2 Apr 2020 15:14:17 +0000 (UTC) Subject: Re: [committed][gdb/testsuite] Add test-case gdb.dwarf2/break-inline-psymtab.exp To: Pedro Alves , Tom Tromey Cc: gdb-patches@sourceware.org References: <20200309145237.GA20334@delia> <874kuv7nxk.fsf@tromey.com> <871db4cd-d537-e99a-3199-d5b6a76ed30d@suse.de> <0fd8fe6f-be5f-3895-f67a-744bcc456ca6@redhat.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <41f0adf0-878f-25b0-ec85-e05cc3ce8fb5@suse.de> Date: Thu, 2 Apr 2020 17:14:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <0fd8fe6f-be5f-3895-f67a-744bcc456ca6@redhat.com> Content-Type: multipart/mixed; boundary="------------BB459D0BE108A76B8E99CA75" Content-Language: en-US X-Spam-Status: No, score=-32.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 15:14:20 -0000 This is a multi-part message in MIME format. --------------BB459D0BE108A76B8E99CA75 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02-04-2020 16:24, Pedro Alves wrote: > On 3/18/20 1:48 PM, Tom de Vries wrote: >> +set sources [list $srcfile $srcfile2] >> +set opts {debug optimize=-O2} >> +if { [prepare_for_testing "failed to prepare" ${testfile} $sources $opts] } { >> + return -1 >> +} > > Is that -O2 needed to force inlining? > > -O0 and __attribute__((always_inline)) would be better for that. > Ack, thanks for noticing, fixed in commit below, committed. - Tom --------------BB459D0BE108A76B8E99CA75 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Don-t-use-O2-for-inlining-in-break-inline-psymtab.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Don-t-use-O2-for-inlining-in-break-inline"; filename*1="-psymtab.exp.patch" [gdb/testsuite] Don't use O2 for inlining in break-inline-psymtab.exp In test-case gdb.dwarf2/break-inline-psymtab.exp we use O2 to enable inlining of bar into foo in break-inline-psymtab-2.c. Instead, enforce inlining using __attribute__((always_inline)), to avoid any optimization-related test issues. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-04-02 Tom de Vries * gdb.dwarf2/break-inline-psymtab-2.c (bar): Add __attribute__((always_inline)). * gdb.dwarf2/break-inline-psymtab.exp: Don't use -O2. --- gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c | 2 +- gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c index 38c69336f2..b7fe485b3a 100644 --- a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c +++ b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c @@ -19,7 +19,7 @@ extern int foo (void); int a; -static inline int +static inline int __attribute__((always_inline)) bar (void) { a = 2; diff --git a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp index adbe8620aa..344d7da0d5 100644 --- a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp +++ b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp @@ -16,8 +16,7 @@ standard_testfile break-inline-psymtab.c break-inline-psymtab-2.c set sources [list $srcfile $srcfile2] -set opts {debug optimize=-O2} -if { [prepare_for_testing "failed to prepare" ${testfile} $sources $opts] } { +if { [prepare_for_testing "failed to prepare" ${testfile} $sources] } { return -1 } --------------BB459D0BE108A76B8E99CA75--