From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 47329388981D for ; Mon, 13 Nov 2023 14:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47329388981D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47329388981D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884458; cv=none; b=sGWdTYckb8dR/9u5rbV0/h1vzTUkgr4Hh5IMW1ifMJlI3tExINDHNKOdv3MlXVwGnFbwxFHduZYHujpm1vi4Yyrs11EqWRkeJGvc++ZjZ85J5cVEAhI2HLehBXicyRQxJkN3ihpNlULvDubGvxXlqKCCjnLDD5tqza87SAGodow= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884458; c=relaxed/simple; bh=ELe0Jc5hR14Io/0FWqQl9dTkfpfSavtkUADvwC6hBQg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=Uy85IztdTaHgLfFRKDWrvoOzMQ68IQjsrIlvCxTEYMti4pvPBU9vnt//UwyWcwTaiZI81V//KcIV6xu6J2kj0f3xn3TTZiLmBGAhv10J1XZgOEypJnCO6ERJ+hAOVpVSMxcdI+DNhtpwOcB4Po6UbaFG3XE8tJ0NCilE8Jd72TQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-32fdd0774d9so2724257f8f.2 for ; Mon, 13 Nov 2023 06:07:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884456; x=1700489256; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sn1J59DsHI5z2fOk6lC636VVA06KuimV7cDuwtrCgYY=; b=HUrnYolpLxtMV+82EeVYr8GqQjN6itwKD61xj0VeNYpv2tDtoBag7yjgpFcop+D9K0 LI0TN2dDmlCrVjDU/Utr63eYU3oUSD84Dvk9/oJ4RMTB5iJbivT4rd4r0KIidkWxd+6K Q94GFaI2L8jTaWZd8Atq7b2JsN/KTdYAH9coGgovUYC+fALa9Flek6XFL3lK/xBjt6h2 2sYt21xrjcVfuObj3pp9deUDP7CyOsXN7kcaynszrnmTD7FkZHEvJH10mKfLFjJxTiS2 ZHi/+9WZvn8qqp0HdjYh8w8EucGLiCmdfBE0tcW591+U0Mfla8+A9YJn2YzZ7yHYqof3 d7NQ== X-Gm-Message-State: AOJu0YwfzpVnWgXt9ybypno5MhENvLE4v/HCTxsFnqIAyTF1jqApVPQh 2W1HPnIBS5DVId8DaZaBwj2lRYFLyE8= X-Google-Smtp-Source: AGHT+IGFN0BldbEQnArLtWvF84JFM7H/lKcB8n0w+4HWsrrzgDwoQPr5oL/iv/eFjAECXNSMZ3ZL9Q== X-Received: by 2002:a5d:6d01:0:b0:32f:8c3c:dddc with SMTP id e1-20020a5d6d01000000b0032f8c3cdddcmr5789414wrq.2.1699884455955; Mon, 13 Nov 2023 06:07:35 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:8060:1e54:fb28:9635? ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with ESMTPSA id w7-20020adff9c7000000b0032fbd0c7d04sm5525593wrr.55.2023.11.13.06.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 06:07:35 -0800 (PST) Message-ID: <41fedafa-ddb6-4e37-82d0-6618fce53622@palves.net> Date: Mon, 13 Nov 2023 14:07:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/31] Thread options & clone events (core + remote) Content-Language: en-US To: Andrew Burgess , Lancelot SIX Cc: gdb-patches@sourceware.org References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-9-pedro@palves.net> <20230131122503.x6aameca5zjuu7kp@ubuntu.lan> <47bca489-7d80-f2ab-f0df-f36d550304c4@palves.net> <87mt1c3ei8.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87mt1c3ei8.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-06 14:29, Andrew Burgess wrote: >> @@ -577,6 +589,10 @@ class thread_info : public refcounted_object, >> left to do for the thread's execution command after the target >> stops. Several execution commands use it. */ >> std::unique_ptr m_thread_fsm; >> + >> + /* The thread options as last set with a call to >> + target_set_thread_options. */ > I think: s/target_set_thread_options/set_thread_options/ here? Yes. I fixed this. > > Otherwise LGTM. > > Reviewed-By: Andrew Burgess Thanks!