From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5974E3858D20 for ; Fri, 20 Jan 2023 17:09:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5974E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E95E51E0D3; Fri, 20 Jan 2023 12:09:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1674234570; bh=8s2K2IHYB6H29VyOVVuGrty8B+Pa6rf+NRFXYh630RU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=IctbKZAnEIYX42tSgIGQrJuZkaaLWeDcNVMJkTTeppsNWNdgbZw6wp5VvvffmXO/U fDT6m08DMjZXjz7hJAupmQDkgvQXTz+Tp2Evdz1AddTOaGjTNEO+epteLbjssvpVRY d7nKK+fNQE/WsvaRfLzrWN8kzkLao1N6jRMVVNbA= Message-ID: <42144c46-2268-a613-0356-9860f4982441@simark.ca> Date: Fri, 20 Jan 2023 12:09:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Use bool in pc_in_* functions Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230119173836.653968-1-tom@tromey.com> From: Simon Marchi In-Reply-To: <20230119173836.653968-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/19/23 12:38, Tom Tromey wrote: > I noticed that pc_in_unmapped_range had a weird return type -- it was > returning a CORE_ADDR but intending to return a bool. This patch > changes all the pc_in_* functions to return bool instead. LGTM. Simon