From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70077.outbound.protection.outlook.com [40.107.7.77]) by sourceware.org (Postfix) with ESMTPS id D5FCF3858D39; Mon, 1 Aug 2022 14:17:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D5FCF3858D39 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WNb4fapOQeL/w6z41UvKb/h8DmRw2JXahR1IWfV9n0ckggvBwFbzw88dzuIPfUTWDj+J8F2sbVVIT2OJdPNKevg53qjISfezzxLr4buprK1qlqwV33+PGp+sE9GYS8GN8Qb96NcoaciVgFh/3ogCl9WdLpOWvYaZEU2aclWteVm6OsblN4ydigg5/2gZ5petOp1p5XjwFeALM3EipX/dYC5f1V8Vt+ZvWlyISem57qZkC5w4J92TmuFvy8XOM9QC8IeAR3lcJr/xndens6HYxsmy8SreJhkQHkweG4ZKOCFDyEbUmFssheKQ3deac147vB3EJq5NMfhD70orIhzmHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P8Th2pwFTV3phx8i6r6iRZm98vfv08N6rIUJBA8WyfU=; b=X83f1dHGgq+ie5ZwbcXabQ/DZfr6ohTlW598hMOFJVR9e+yZMw1vjCCZqNTvXDYorNCkZsYnz60jVbqtQdoNhizCG04o48yLhFKB++37j+GdGGB1KDixWFy2QTi1PcYBbY8Ykci2UVCoN58/4rxOkEDSJWPsXzd9XS/f7vbRssuCb6eZLNCXiOjJV3OSp1d9UdVuDYXhcWhjPnsJUXWUjxZQYVh5YRWgVMWdyoxztEt7UbE4mLxvEBBni9gKxOY88W8XKaVSSGXrP4tuYM3mCLv1iMTJGcvV+UxkeAnRRDEzAenk6xYwoaANTyJQbZcoKu4UYw1QN/T6MjGC7T0Dpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM5P194CA0018.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::28) by AM6PR08MB3157.eurprd08.prod.outlook.com (2603:10a6:209:48::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Mon, 1 Aug 2022 14:17:26 +0000 Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::5) by AM5P194CA0018.outlook.office365.com (2603:10a6:203:8f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Mon, 1 Aug 2022 14:17:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Mon, 1 Aug 2022 14:17:25 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Mon, 01 Aug 2022 14:17:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1bbc23ed9e2bef39 X-CR-MTA-TID: 64aa7808 Received: from fffc07f0bede.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FF059076-EBC4-48B7-9714-4F3A4E4CCC40.1; Mon, 01 Aug 2022 14:17:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fffc07f0bede.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 01 Aug 2022 14:17:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfABN5sTg/DSJ9w0Dsu1xD4L75XANmnjTuISDsWqTJdYnv/qIxOevdYxNtSaV9JlrB/rAsqIyeFMKQt7LJyO0/UqZpyF6m96s9YyleCs/DCjxpbvSkwBFGXHCE+FpJI28/irlaLMd9/r6L0QbPGoTZyCLGrZyjzOb82C5bgr88HC5RZCvBh3nHOCeJifcjsUgoqr1z210+KYcjLl/4kizMiWbmPggQAXw4P3ZE+JiyEhHjoJYMC5XZ3jcYM0BnBaf6RPMNGYdrZxu+bfONflZSirYAfeBByYNmeoOrcPUt0o/1c0qgl1ocjhezonH4pz+lxHLqNBCKyeEc6M8EfXSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P8Th2pwFTV3phx8i6r6iRZm98vfv08N6rIUJBA8WyfU=; b=WpXgfeDgQ66EyJMbS2wOqCWbew8+YwpMgeYqtZ2avgf5EIX5C3j6jaPRTirpyPXO6Vh3ctxmpPd42QfPtS2urVAmlvcqk7i98jxYZ6IK48JboD+XWCZDienTUbx2U3pr0sBdu5xLj9IWBPC9VUv0tMOP7jy6w8j5pxPtyWiqhMcMa+OKgSB1uqbwBQ3zyvFMzgrElp0z/NviSMRtGlaJMWwyDgojNWDCjIneuaDUjmn9TnULRC9GVtEZ1JRhhMBZgWQJ4g6Y2BNc3JJ1sY0SX2BKGcpjjrjG9SYwzeAY3hAngI1PCh9mxWI8YmA70+MxhV066ebo7sroCH8nvTCxiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB6PR0801MB1943.eurprd08.prod.outlook.com (2603:10a6:4:74::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.14; Mon, 1 Aug 2022 14:17:17 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7%5]) with mapi id 15.20.5482.014; Mon, 1 Aug 2022 14:17:17 +0000 Message-ID: <4224183e-e2c1-9a98-7e41-61a58e49aa29@arm.com> Date: Mon, 1 Aug 2022 15:17:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Disable year 2038 support on 32-bit hosts by default Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org References: <20220801075149.1152064-1-luis.machado@arm.com> <959a19b9-b2c3-6638-e0b9-b66ca8328574@simark.ca> From: Luis Machado In-Reply-To: <959a19b9-b2c3-6638-e0b9-b66ca8328574@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0452.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::7) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 532f408a-12f7-4bfb-0845-08da73c88f2d X-MS-TrafficTypeDiagnostic: DB6PR0801MB1943:EE_|AM5EUR03FT019:EE_|AM6PR08MB3157:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: au2+MbbUKl8Wg1XlLYiQ8K3i1zVsrzsYhy7kKPADhkPElIlGgQX/VTaZru7NPklmNC9S9LT/sw4D2bHPD5+cuxEUM6skV/DFqbY1aiSRDEkDGLjVpi1pEH8rlQzsWm0nmvvxzvnujMXhgmcJF9CpUL7cGQ0opH3pHpB6stxjjrKCch7v46VSw+JJwetxEfIlfcXj2QGgofzgzLDGkcho0PojXquk6paJV1caZ3gaHNiY4XDPGh4gvXeQRHHRgyR+o18xF3hrqkpsRZx6MAelmWRMG+y0ov6Zb1VgHh3yVfdLDQNCIKzAJ/pXN3gD9cryNkKOCwGftn4x62vT5iWZwT66y8aHA0VsQrd/5HWdTBHstKKzOrQafATOd4x9+o1JOm+GyLeyjw4tNoUNq9XW6IL+wgdmoVfpd/4AXJ6XEvrDHaR+DXm4S9UNVfRX1JG6jAJRRX7j7bCbiCo5LWUhQ1JmAhuc0fX+GLpMKkyNd62lQljIAJOH7aGQZ+rWa7rtnKpoTRDGuWqr2p7txvjOtCp4anVwrRjrrtROeZ6gLazRNCpL2+CSXtzhSrCa7lQ/PTlglSyQKB891YYNUsJCwGSsdiUYf60xk5eSIzegsDfnqX8q8hbgrUAU0zuHtqXFyhqoCwLPAWUt3dZSGorVbhgZzpJR2HgF5cF2ikl9EuU1AZmXuObpiSD9r4afi2vqNlVzzrGvXIVj9j4i2CuygxF41u2eT7+L2vQ18o7/dB+/GRZaEt05LWt5jAZklK7QWGqgUNMCAWuiT/JsKvHWBti0FdRjH1lUiLOARUwS72eAchMJL9ZMlLpvrLJNbEIRcIY2Dz3ZJCJm7dSCAVNjAA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(366004)(136003)(44832011)(316002)(6512007)(26005)(5660300002)(8936002)(2616005)(66556008)(66946007)(66476007)(186003)(38100700002)(8676002)(31686004)(41300700001)(478600001)(6486002)(86362001)(31696002)(6506007)(53546011)(2906002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1943 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 80a76585-c6f6-435a-d895-08da73c889d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhRbAYRRvBkpYldNSnWJNSKdvwTmQksEbrezo/YT4/f0BPwcspfz9sUVSqdBWkdwD5AmNeGsAvu6lJ/UpWDM5WrSN/AQ9RfnbZFq88/IifcL1AO/bwa7HjKiZQeZ5JDxjxgyG0Y0DbqDubC9SGUI0MprnwN6H+qz8EWLqFwlFZQdOtF3yvFCZDF5iq0o7Z+mi+uY1kT2NOKOKTQd9D+MTVTm/aegMdKLZiOULCiLBsepxvX6Pq4J63q+ZdqsjTAlJ6AZ7Wg4aEBl0GZOxhsKB1u3wtWnCFBP7VHsmW2Q47Ih1/Oh7nqsRQdfFfXM7bmWa8xb4ZK52TVOBAc4D1xm01adX/w8z5dSJLHSG4hQASMvdVnzaiVY3ftlZEU4Jk+0zP7x3ADK2ot1VSaeZr2Cku7vcdmmSm1RPnkQE3rQZ3hNHz51oszDGii7eQT5SsdNORZ94lTHSr3Us0Y45/WuH5XbGCFfFsXxFT9JreGCR8sdCCafvPpCw8G1BpPkmYfaXc2skGyRCxww+Z4ZTuBHL3HLmJ0QQIxxAxcK+fTazaHEijttgOSmZj9ASXu+qZH78D3vOeBEIZrZ52mXvYjkF5bQI2Go99E7Cwf7lfUt14lB2xsi2upWxNJxmAwxPDg0snOg82XMo6cVMqsyoEXm7cG/k2ItWnWLXL110NIoWdbTi20A6rDDluxtV9vinMQl24VBM6/E90fIzGQ6ohoItACuRbfTOaIilvpTCmgXhSIoUv5wJmyAg4DVeYawbgh2T9WoNkCDy2nPDusz3hLJ4qfq3+9CXcDXdiBm+yItw7WrbyR4nsJRAkc40MEAasowNx0itWZ1BjDZ63gbuXwKJA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(346002)(136003)(376002)(46966006)(40470700004)(36840700001)(70206006)(70586007)(2906002)(36860700001)(8676002)(81166007)(82740400003)(356005)(47076005)(6486002)(478600001)(316002)(40460700003)(186003)(44832011)(2616005)(450100002)(336012)(41300700001)(6512007)(26005)(5660300002)(6506007)(82310400005)(53546011)(36756003)(8936002)(31696002)(40480700001)(86362001)(31686004)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 14:17:25.8311 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 532f408a-12f7-4bfb-0845-08da73c88f2d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3157 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 14:17:33 -0000 On 8/1/22 15:08, Simon Marchi wrote: > > > On 2022-08-01 03:51, Luis Machado via Gdb-patches wrote: >> With a recent import of gnulib, code has been pulled that tests and enables >> 64-bit time_t by default on 32-bit hosts that support it. >> >> Although gdb can use the gnulib support, bfd doesn't use gnulib and currently >> doesn't do these checks. >> >> As a consequence, if we have a 32-bit host that supports 64-bit time_t, we'll >> have a mismatch between gdb's notion of time_t and bfd's notion of time_t. >> >> This will lead to mismatches in the struct stat size, leading to memory >> corruption and crashes. >> >> This patch disables the year 2038 check for now, which makes things work >> reliably again. >> >> I'd consider this a temporary fix until we have proper bfd checks for the year >> 2038, if it makes sense. 64-bit hosts seems to be more common these days, so >> I'm not sure how important it is to have this support enabled and how soon >> we want to enable it. > > I don't understand: why offer a --enable-year2038 switch if using it > would produce a broken build? That switch is already offered by gnulib since the recent import, and it is on by default. So in practice it produces a broken build for 32-bit hosts running a distro that understands 64-bit time_t. It's been broken for a while now. What I'm suggesting is having a temporary fix so default builds aren't silently broken due to a mismatch in stat size between GDB and BFD. It isn't clear to me if we really want to switch to 64-bit time_t for 32-bit hosts at this point. There is potential for more breakage.