From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Include <alloca.h> conditionally
Date: Tue, 17 Mar 2020 21:20:37 -0400 [thread overview]
Message-ID: <422bea2f-d596-bb4a-b42d-74153226a317@simark.ca> (raw)
In-Reply-To: <20200317140312.1367-1-n54@gmx.com>
On 2020-03-17 10:03 a.m., Kamil Rytarowski wrote:
> Fixes build on NetBSD, where alloca() is defined in <stdlib.h>.
> ---
> gdbsupport/common-defs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gdbsupport/common-defs.h b/gdbsupport/common-defs.h
> index 65500ce7634..e42d2b80c04 100644
> --- a/gdbsupport/common-defs.h
> +++ b/gdbsupport/common-defs.h
> @@ -92,7 +92,9 @@
> #include <strings.h> /* for strcasecmp and strncasecmp */
> #endif
> #include <errno.h>
> +#if HAVE_ALLOCA_H
> #include <alloca.h>
> +#endif
>
> #include "ansidecl.h"
> /* This is defined by ansidecl.h, but we prefer gnulib's version. On
> --
> 2.25.0
>
This is ok, please don't forget the ChangeLog entry.
Simon
prev parent reply other threads:[~2020-03-18 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 14:03 Kamil Rytarowski
2020-03-18 1:20 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422bea2f-d596-bb4a-b42d-74153226a317@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).