From: Pedro Alves <pedro@palves.net>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gdb: regenerate target-delegates.c
Date: Tue, 14 Nov 2023 11:14:45 +0000 [thread overview]
Message-ID: <4271727e-851e-4650-bab2-c66c735d9954@palves.net> (raw)
In-Reply-To: <b03f96baf03fd61dd4bda47fcd725a07938547a0.1699953637.git.tankut.baris.aktemur@intel.com>
On 2023-11-14 09:41, Tankut Baris Aktemur wrote:
> I ran './make-target-delegates.py' and there as one minor difference,
> where an older style declaration is converted to a newer
> initialization style. Add this change.
> ---
> gdb/target-delegates.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
> index c5540c366e4..a27b66df100 100644
> --- a/gdb/target-delegates.c
> +++ b/gdb/target-delegates.c
> @@ -2291,9 +2291,9 @@ dummy_target::supports_set_thread_options (gdb_thread_options arg0)
> bool
> debug_target::supports_set_thread_options (gdb_thread_options arg0)
> {
> - bool result;
> gdb_printf (gdb_stdlog, "-> %s->supports_set_thread_options (...)\n", this->beneath ()->shortname ());
> - result = this->beneath ()->supports_set_thread_options (arg0);
> + bool result
> + = this->beneath ()->supports_set_thread_options (arg0);
> gdb_printf (gdb_stdlog, "<- %s->supports_set_thread_options (", this->beneath ()->shortname ());
> target_debug_print_gdb_thread_options (arg0);
> gdb_puts (") = ", gdb_stdlog);
Whoops, my fault, missed the need to regenerate before pushing.
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2023-11-14 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:41 Tankut Baris Aktemur
2023-11-14 9:41 ` [PATCH 2/3] gdb: refactor make-target-delegates.py's ARGTYPES Tankut Baris Aktemur
2023-11-14 13:47 ` Pedro Alves
2023-11-14 9:41 ` [PATCH 3/3] gdb: handle default argument in make-target-delegates.py Tankut Baris Aktemur
2023-11-14 11:31 ` Pedro Alves
2023-11-14 12:48 ` Aktemur, Tankut Baris
2023-11-14 13:36 ` Pedro Alves
2023-11-14 14:17 ` Tom Tromey
2023-11-16 18:11 ` Aktemur, Tankut Baris
2023-11-17 15:41 ` Tom Tromey
2023-11-14 11:14 ` Pedro Alves [this message]
2023-11-14 14:18 ` [PATCH 1/3] gdb: regenerate target-delegates.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4271727e-851e-4650-bab2-c66c735d9954@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).