From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 67D153858D35 for ; Mon, 15 Apr 2024 12:44:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67D153858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67D153858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713185058; cv=none; b=ML4ciBuz09U9nso+Ki6nog1tLceZxavlbOOh2bgklRmcgP6UGWL2cAAyHsreu123cQEytPCesYC2rCtDt+hKiw6p6k1dzt2QcOdbZ6HRUk3fLq8eTHgmqX/PypQPInRHnZbHQAmWwLsUFQMR5HEOOZKPSopPL8plgtD85f8kpaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713185058; c=relaxed/simple; bh=STGcK6D5gWNXXTm4xyM0OwvaKbNVABx0FcOmnGxOzSs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qERbuXHKUz5/t59pz7CvgVWfS7SYkV51YYcobg90swLdMYAgxZdipoB8JYyieGnITe3kagr2Y7RaejyR/zGoPM4tMFdeTwVIWG0B9/KbkogPVTcMfTq86Y17DDJoDQXeX3JNpRhdAjxo+aiVMMXnK5SQCvpZKZqtcMX8i/fCMCs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713185056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MgQW6srrB+bQ9g6TOlTjMnqt4TvN1VRJUePQYDPAPPw=; b=IytFGprPTVjq2gQ0tOSSdO41OcwLmrQ9HW8HePrMu03jAY7UKEQzfHBpekCHiIDHH/Z2M7 ocbIc4iSqI3IFv4bZF4zyKVTfaDJgu1+shVOcXikKhA+YRZ0BxsJYd8cpPlLz6xCyRJgEW eBl729jR7RThnlX7mq4WYQVcRwqI4p0= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-T9Eowe8DNt-n54OFzcQKwg-1; Mon, 15 Apr 2024 08:44:14 -0400 X-MC-Unique: T9Eowe8DNt-n54OFzcQKwg-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-6edddd0375fso1462647b3a.2 for ; Mon, 15 Apr 2024 05:44:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713185053; x=1713789853; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MgQW6srrB+bQ9g6TOlTjMnqt4TvN1VRJUePQYDPAPPw=; b=IN9qwrioURkK4kq7j6FaHhE0XvnD9v3aFCceUsQY8wqjkkylmeMmV6MlvwKLP6znmt DR4L2euUJWqV9yZs3iq27m7t30eyNem9KgKydKdzZ16J0813uTadPmtHQ/4wgsuoc2s9 mTkWFOQsn/nROh2XZ2BK1PPVjit2NcI2NSSlgFa7IA71Y4gr8N9FNfuWzYni8AFop6Xj NPqBSFEZi79mSynE/ydr8cN5qQ4t+sgL78z6GiUU3w1QBxTtNfMl0aiWIAdkHHFu5LGL G54xdEhuHiowifxfi78gEyzqNvGRcBOwXuc7ZNuGiCbLP/QpSADy/ilAKutj9sTp16Ll ueiQ== X-Forwarded-Encrypted: i=1; AJvYcCVbC6WDCMPEpE9Il77nKHIqW8NtrmabFSIdcSdvAV+zGeQK96Y2Bk43AvZKRUetIM24vJHTqkKYsKp+n3kl5WvxrTM7zQkTO5JqDw== X-Gm-Message-State: AOJu0YyOmdEEfdkcMoKC0qfUx11hpjZ/ciJPDuQDnCR3MJioadjkMsvS 6w9qdxKP+5/cS3DjsOTZUT6XyISvZvCJ0NCmOXN5oToQ1Hi7kIikkp9be+2Y82HHu9Xsug2pIBL ITyT3oAzAgpK89hEDssITzdA8+dChMHKLMkc+Ym3NFFScn029maNWZiGgs/XbWwSD2zWZ0g== X-Received: by 2002:a05:6a00:3985:b0:6ea:c3bc:2031 with SMTP id fi5-20020a056a00398500b006eac3bc2031mr9742679pfb.7.1713185053460; Mon, 15 Apr 2024 05:44:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE71HeENHn3wT4lRlsjEzCrhMFwhUJUp2Cu3vDGUCG6xRKB84N1AKsMGS36DOcSeXJaTbA4dw== X-Received: by 2002:a05:6a00:3985:b0:6ea:c3bc:2031 with SMTP id fi5-20020a056a00398500b006eac3bc2031mr9742666pfb.7.1713185053103; Mon, 15 Apr 2024 05:44:13 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id f14-20020aa79d8e000000b006ecf00ecfe2sm7343577pfq.12.2024.04.15.05.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 05:44:12 -0700 (PDT) Message-ID: <42993d45-438f-41ac-96f8-47d9d924235f@redhat.com> Date: Mon, 15 Apr 2024 09:44:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/4] gdb, infrun: fix multi-threaded reverse stepping To: "Metzger, Markus T" Cc: "pedro@palves.net" , "gdb-patches@sourceware.org" References: <20240410074613.54520-1-markus.t.metzger@intel.com> <20240410074613.54520-5-markus.t.metzger@intel.com> <049130fa-da68-4834-8655-7e5a1c43de00@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/15/24 06:03, Metzger, Markus T wrote: >>> @@ -179,6 +186,9 @@ struct thread_control_state >>> >>> /* Whether the thread was replaying when the command was issued. */ >>> bool is_replaying = false; >>> + >>> + /* The execution direction when the command was issued. */ >>> + enum exec_direction_kind execution_direction = EXEC_FORWARD; >> I'm a bit unsure of this... Mostly wondering if this makes sense to be a >> thread-specific information. Does it make sense for one thread to have a >> direction being forward and another backwards? I would think this is not >> a good idea (if not impossible). > You can have one thread going forward and the other going backward. > Both are replaying; we do not allow recording one thread while another > thread in the same inferior is replaying. Oh you can? I didn't know btrace was this fancy! The whole series seems fine to me, then. Reviewed-By: Guinevere Larsen -- Cheers, Guinevere Larsen She/Her/Hers > > Regards, > Markus. > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928