From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50050.outbound.protection.outlook.com [40.107.5.50]) by sourceware.org (Postfix) with ESMTPS id 722443858C50 for ; Mon, 21 Mar 2022 09:29:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 722443858C50 Received: from DB6PR1001CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::15) by AS8PR08MB6886.eurprd08.prod.outlook.com (2603:10a6:20b:397::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Mon, 21 Mar 2022 09:29:08 +0000 Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::5f) by DB6PR1001CA0005.outlook.office365.com (2603:10a6:4:b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.13 via Frontend Transport; Mon, 21 Mar 2022 09:29:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14 via Frontend Transport; Mon, 21 Mar 2022 09:29:08 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Mon, 21 Mar 2022 09:29:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cd5e0d083f7bac83 X-CR-MTA-TID: 64aa7808 Received: from 88c44c2763e9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CE527E9F-E132-4801-89BB-A94D33545E29.1; Mon, 21 Mar 2022 09:29:01 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 88c44c2763e9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Mar 2022 09:29:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHCJQuhXRJX7agaSdKF98FUhc0KmHA9MwvxEUKuo5UAFeaIwZREAw5sJDH6OAYI9GhW0KzPnwSV9xdbcU4kBaVuNwTPL23L/VLv8uLuNeVNqE9nIp56SUKfaFj+UAAY8foUnntn5C4K4Q9h4UBShqBxQXrXgqOrLiq6vpRcpK37E6LV0OWebKP4kY2522MRLSivVHRWPOa0IOJ4Jm2ImPSn1mhtr0R2qgQPN/V+6ZYI1nUN2YKQ2+9NmHjKhEKP/0WzlQWuIiJvUCzdqZPzEY+LKqp9ryVmwGQZRYluaLd/NKG0WF64Ebx1e7C1rR8BHmYOrwNczMmsH5xO/bHd9Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vTg4XfG0PS8G9ryUQ/NR7X6N1iefv8PCwmnITHNsbG0=; b=lSK6/G0QZkQYqQ8xLyq1UFD1OvFL+EbYxgp40r8E02PicJE2PwbDyaWRHYdtV9Nze3EyJKX4HO1U/EOwDUKch7tf9zMpDF1vjpRNmE64LRc7D7zYCj7RFq+LQu4d3jsmIkljjmToUOusvM7D2P8ddMRkYNCScOk9tecfuWb+Et4XoqZzs5XxX5qzp7VCezkwiHYacL21eSMADPYtBV8o+0Fuy4+yN9/G8Y5rI78V7qNni7INy+hciyV1la1oTAarLvVE2Hhgci867sW8Qhy8fBBi0vg4Za/gKHQvrwRkBMbheH9zYdKdTn9ZzIM6RaeIUkEKEe3M0nJD4FVGvyYm7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by HE1PR0802MB2297.eurprd08.prod.outlook.com (2603:10a6:3:ce::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Mon, 21 Mar 2022 09:28:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e%7]) with mapi id 15.20.5081.022; Mon, 21 Mar 2022 09:28:52 +0000 Message-ID: <429bc573-999a-86d7-cf70-bb685c7f457d@arm.com> Date: Mon, 21 Mar 2022 09:28:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/3] Implement real literal extension for Ada Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220301170055.1520935-1-tromey@adacore.com> <20220301170055.1520935-3-tromey@adacore.com> <77f98638-ec8f-5d79-8a00-d91db1253644@arm.com> <877d8ri1af.fsf@tromey.com> From: Luis Machado In-Reply-To: <877d8ri1af.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0352.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::28) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 72531ff5-5fcb-4c3e-4774-08da0b1d4036 X-MS-TrafficTypeDiagnostic: HE1PR0802MB2297:EE_|DB5EUR03FT043:EE_|AS8PR08MB6886:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3WofhZwrbYlC8dl7enhLgCdkZWWXtnBPT6Slwk4dbx8jV+OKngve3nGzgx3+N1w42YaiKrPdCCuWNxCU5WIgBRtUVSJAK1TpZzmADNT+u3dzseS8rb8Cf45DqyYkiEyODd+k42o+QCrp0eMcRT6J5hmBrJsAnreEY6IM0wmO1RigiW3uYfPc+chnEtgMOEQZkSmnhHXvsSf7GchEaPvY7QLHWN2YHGACcvtI00RWxR0UjlUJOpKYygdR8FCpgn5QJdfWo8lqzXEfaCy0gRkQWeQt35qZR+kYuRTRYyknFhgv5eEqUuSdEzo1/R/hEUePGUE2ySUAGq5/reEJE2Ws+nAdaH9mcNKHGfj4lUfu0yVDEM0+0O8iyKyunkaNdXPIxd6gOmfB6gEL0ZkANnWN21TyEHuuvS3oVnvqRTg4kpo47A0beWJocSU19TWfJfshiexJZPMarebGBxMJq/qzO8zJhdNvnsbOWXF2KnmjhL93bcggfI/9UYrdvdOOl3bvfOtJ9yVO7RvIaQIDXKFIEsxAzMn7H7BRnAx81+stoo9J6m30hwQkiklO+EEHbUJw4YsdDSDc26tZuHUWHfB+kBVGnfUJFggzkusTSptb2tbkVrw1dEVOJC60RLAMwVptSr6kt1dWOI/S8lH5aDG98KqnmJ5zjMgymc3in72pYs6jOkCr45/OiypMgNIp/aE6anhBriqD9r6upCD19tDgH3MOKdUzPBT/AjTSY7jlLYIbhrfwBufpt6aWHuq52yvoD+Ir9rXRJm/Ml2C6XqggqJnm+AazTPXCraQtnkQ5TiOlr6pyzc0hi/N/XKrypbWW X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(86362001)(31696002)(38100700002)(508600001)(6916009)(6486002)(316002)(2616005)(53546011)(36756003)(6506007)(26005)(186003)(6512007)(83380400001)(44832011)(8936002)(5660300002)(66476007)(66556008)(8676002)(2906002)(66946007)(4326008)(31686004)(6666004)(84970400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2297 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 32a901ab-6e58-4cfe-f6bd-08da0b1d3610 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 57snekxy00U5NttoSJ+r5U7lFqE4pjqyHOJl+zrTYAM1EE6alGxfTY5G82hkOoM7uxhQWranJqgXDejw6t4eBdEtQndMWuXOBr3+WQSObHasIr93+5C/RwDWZtt6gR5KQcMgiBmFVdgVpgXhxyW6VpNx0rZcglgi47ICo9YCGLoDGpqVP/wSUSUIFAHs+oypdoVmN63KWMfxvnLmgFmV8yjPwmCSCPZ/jWug1xcmE/+5YfwQhiK0q5iPGWpgWr7hjt0FNeUuDuUi42wDZ8OjybQ9Dxq3v0/sBk53TG5GHlnTMpop/E5jIG2VoVKraDNBrDMbpAxkEpEYTJUFqvvO/Yl37Y4h+gfp439WVbvfcdaF2OM9vKwZeeG09Q/Jv2GD1FgntjO4/hkbRlcMopBtXi6y5ZuKUaHkDefZdKNEHlIOf+ZOCeCDaENSixsp3CAFGjNiCEunc/1ndLHV9/rvf1Z3bidsKIjeeOAP95s3zQ6L0PxoG7L3d2qG2FizQadP2w0n+6Ku++s3kY6+v4nXDFY+9gDFwup82IyDztLMMGF7G/+peiSCTGUoJ4kdmfOn/nbVzPF6upqeppKaRWjULVtnSUA9aQhZx+/EjmS8lFJH5bNTbIwFX1wJantvxl/BTFnt8l2d7ShxoOnXmoWKRHyvW+SdAfuWC0JiSX8t3zfZk1cBLLQ+NwG3kiLhw/hqeR149iX84NfoCcCivAfrRAHVDoMwvGeYdUiOvmagEQKNaA2Qvdvk8WMuXu6/VScxUCQpybuprY+6YqJV9+3XOP8LalGQXY1S/EmuVrMnzSo= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(84970400001)(82310400004)(316002)(83380400001)(336012)(6506007)(2906002)(6486002)(36756003)(53546011)(31686004)(508600001)(6666004)(6512007)(36860700001)(2616005)(356005)(6862004)(70586007)(70206006)(31696002)(44832011)(81166007)(4326008)(47076005)(40460700003)(8676002)(5660300002)(8936002)(26005)(186003)(86362001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 09:29:08.5446 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72531ff5-5fcb-4c3e-4774-08da0b1d4036 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6886 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 09:29:14 -0000 Hi Tom, On 3/18/22 18:05, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > > Luis> I think the floating point representations may differ between > Luis> architectures/bit-sizes. > > Luis> I noticed 5 failures in this test for aarch64-linux and arm-linux. > > This is interesting, because internally we have a rewrite of this same > test, and it seems fine on aarch64-linux. > > Luis> FAIL: gdb.ada/float-bits.exp: print 16llf#7FFFF7FF4054A56FA5B99019A5C8# > Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double > Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double := > Luis> 16llf#7FFFF7FF4054A56FA5B99019A5C8# > Luis> FAIL: gdb.ada/float-bits.exp: print val_long_double after assignment > Luis> FAIL: gdb.ada/float-bits.exp: print > > Luis> Some of the expected values don't really match. If the output is > Luis> supposed to differ, maybe we should compare hex values instead? > > I'm curious what is show by 'print/x' of the various values in there. Here's what I see on my end: (gdb) p/x 16llf#7FFFF7FF4054A56FA5B99019A5C8# $9 = 0x7ffff7ff4054a56fa5b99019a5c8 (gdb) p/x val_long_double $10 = 0x4544adf4b7320335 (gdb) p/x val_long_double := 16llf#7FFFF7FF4054A56FA5B99019A5C8# $11 = 0x0 (gdb) p/x val_long_double $12 = 0x0 (gdb) p/x 16llf#a56fa5b99019a5c800007ffff7ff4054# $13 = 0xa56fa5b99019a5c800007ffff7ff4054 (gdb) ptype val_long_double type = <8-byte float> (gdb) ptype 16llf#a56fa5b99019a5c800007ffff7ff4054# type = <16-byte float> > > Luis> Also, for 32-bit targets, I'm seeing size-related issues. > > We're also doing testing on ARM and that seems fine. > Interesting. I wonder what's different in my environment then. This is standard Ubuntu 20.04 on aarch64 hardware. I usually build --enable-targets=all, but in this case I tried a single target and it did not change things. > I did disable some of these internally for some targets, ones with > "weird" floating point. > > Anyway, it seems like we could change the test to verify that the size > of each floating point type is what's expected before proceeding. But > I'd like to understand the above a bit better, first. Please let me know if you'd like the full log and/or some more information.