From: Simon Marchi <simon.marchi@efficios.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 07/14] gdb: remove BLOCK_RANGES macro
Date: Thu, 21 Apr 2022 14:57:21 -0400 [thread overview]
Message-ID: <42e8fbf3-abeb-9e32-a8ef-8cb03d468db7@efficios.com> (raw)
In-Reply-To: <b27d9f0f-3c2a-d2c8-0470-062077a6b221@palves.net>
On 2022-04-21 14:16, Pedro Alves wrote:
> On 2022-04-21 15:59, Simon Marchi via Gdb-patches wrote:
>> + gdb::array_view<blockrange> ranges () const
>> + {
>> + if (m_ranges != nullptr)
>> + return gdb::make_array_view (m_ranges->range, m_ranges->nranges);
>
> Given this is a const method, shouldn't this be:
>
> gdb::array_view<const blockrange> ranges () const
>
> ?
Hmm indeed. It needs both a const and a non-const version. Fixed locally.
Simon
next prev parent reply other threads:[~2022-04-21 18:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 14:58 [PATCH 01/14] gdb: remove BLOCK_{START,END} macros Simon Marchi
2022-04-21 14:58 ` [PATCH 02/14] gdb: remove BLOCK_FUNCTION macro Simon Marchi
2022-04-21 14:58 ` [PATCH 03/14] gdb: remove BLOCK_SUPERBLOCK macro Simon Marchi
2022-04-21 14:59 ` [PATCH 04/14] gdb: remove BLOCK_MULTIDICT macro Simon Marchi
2022-04-21 17:33 ` Lancelot SIX
2022-04-21 17:49 ` Simon Marchi
2022-04-21 14:59 ` [PATCH 05/14] gdb: remove BLOCK_NAMESPACE macro Simon Marchi
2022-04-21 14:59 ` [PATCH 06/14] gdb: remove BLOCK_RANGE_{START,END} macros Simon Marchi
2022-04-21 14:59 ` [PATCH 07/14] gdb: remove BLOCK_RANGES macro Simon Marchi
2022-04-21 18:16 ` Pedro Alves
2022-04-21 18:57 ` Simon Marchi [this message]
2022-04-28 10:47 ` Andrew Burgess
2022-04-21 14:59 ` [PATCH 08/14] gdb: remove BLOCK_NRANGES macro Simon Marchi
2022-04-21 17:38 ` Lancelot SIX
2022-04-21 17:52 ` Simon Marchi
2022-04-21 14:59 ` [PATCH 09/14] gdb: remove BLOCK_RANGE macro Simon Marchi
2022-04-21 14:59 ` [PATCH 10/14] gdb: remove BLOCK_CONTIGUOUS_P macro Simon Marchi
2022-04-21 18:16 ` Lancelot SIX
2022-04-21 18:59 ` Simon Marchi
2022-04-28 2:39 ` [PATCH 01/14] gdb: remove BLOCK_{START,END} macros Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42e8fbf3-abeb-9e32-a8ef-8cb03d468db7@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).