From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2A5D7385783F for ; Mon, 8 May 2023 14:59:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A5D7385783F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B00EC1E114; Mon, 8 May 2023 10:59:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1683557978; bh=ZPcPQ0YBYV7g1dlzHrjhgEqWbp6BUjpmsgDcUAGSmj4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=dggB+EOnb28T39080KgTKL3ddR2ja2Sf4aJ+mKj4ia7Le3DS2oTvtuXB9vCpddWah PN1So3/NMseAJ3MBtb+yuAKaSVor/oG4BkQVYCt9SbNj2KN45iz2U+BmSDFn9nE25L fbElfbmgVdOyIitrZ3zACJBapKE4pwTf+gFvF+nI= Message-ID: <42f0ef87-b803-e614-176a-7c576117fbf2@simark.ca> Date: Mon, 8 May 2023 10:59:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 4/4] Remove ALL_BREAKPOINTS_SAFE Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20230416-remove-all-macros-v1-0-f118956faafe@tromey.com> <20230416-remove-all-macros-v1-4-f118956faafe@tromey.com> <7936dc5e-12ca-bf6e-dbfa-54f6f690801e@simark.ca> From: Simon Marchi In-Reply-To: <7936dc5e-12ca-bf6e-dbfa-54f6f690801e@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/7/23 22:24, Simon Marchi via Gdb-patches wrote: > On 4/16/23 12:28, Tom Tromey wrote: >> There's just a single remaining use of the ALL_BREAKPOINTS_SAFE macro; >> this patch replaces it with a for-each and an explicit temporary >> variable. > > Starting with this patch, I see: > > (gdb) PASS: gdb.base/stale-infcall.exp: continue to breakpoint: break-run1 > print infcall () > ================================================================= > ==47472==ERROR: AddressSanitizer: heap-use-after-free on address 0x611000034980 at pc 0x563f7012c7bc bp 0x7ffdf3804d70 sp 0x7ffdf3804d60 > READ of size 8 at 0x611000034980 thread T0 I just sent a patch for this: https://inbox.sourceware.org/gdb-patches/20230508145913.29359-1-simon.marchi@efficios.com/T/#u Simon