public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@yahoo.de>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add _sigsys info to siginfo struct
Date: Sat, 8 Jan 2022 13:18:43 +0000 (UTC)	[thread overview]
Message-ID: <433810429.4534554.1641647923833@mail.yahoo.com> (raw)
In-Reply-To: <YdmHGwRR9aIbpf0T@adacore.com>

 Am Samstag, 8. Januar 2022, 13:44:15 MEZ hat Joel Brobecker <brobecker@adacore.com> Folgendes geschrieben:

> > > > This patch adds information about _sigsys structure from newer
> > > > kernels, so that $_siginfo decoding can show information about
> > > > _sigsys, making it easier for developers to debug seccomp failures.
> > > >
> > > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24283
> > >
> > > Thanks for the patch.
> > >
> > > I'm trusting you for the proper definition of the various fields.
> > > This looks reasonable to me, but before we push this, I'm wondering
> > > what happens when debugging on a kernel which does not support
> > > this feature? Is the data undefined? If yes, do we a precendent
> > > for this already?
> >
> > As I understood it, if the kernel doesn't support this feature, then it will
> > never send a SIGSYS signal, and so you wouldn't care about these fields.
>
> I see; thanks for clarifying this for me. The patch looks good to me.

Pushed, thanks.


Hannes

  reply	other threads:[~2022-01-08 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220103185854.1675-1-ssbssa.ref@yahoo.de>
2022-01-03 18:58 ` Hannes Domani
2022-01-08 11:03   ` Joel Brobecker
2022-01-08 12:34     ` Hannes Domani
2022-01-08 12:44       ` Joel Brobecker
2022-01-08 13:18         ` Hannes Domani [this message]
2022-01-10 15:12   ` Tom Tromey
2022-01-16  9:39     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=433810429.4534554.1641647923833@mail.yahoo.com \
    --to=ssbssa@yahoo.de \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).