From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AB8CA38FEF43 for ; Thu, 6 Jun 2024 12:50:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB8CA38FEF43 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB8CA38FEF43 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717678255; cv=none; b=YxtY8ZaM6jm4TVBUzDiHG6GUxRwvYDbqIb75OGAul9ZzpIMQ03fxJrID/7+JluB+e2JldZSFof08qqIGYyYPV59uQow1BSly49c3ZxEJmRiC6AXgZLxXh+KD57Gke3mcKPqvapQteWho+6ZXfSJDxpFoyeXRl0Ppvroe8BVN/jE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717678255; c=relaxed/simple; bh=zbliIfra0rQZktot6X5ahTyIKT/gdzqCqMeHWMNd2W8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=x7xQtiaNE33jS8gdrb4qrYYONhp5c8u9HsZ7UA/XXsYUXX9XN1SYsEGF4Exo87SoSoG5evwTK4S6Ngb47K5ox/Kl0fOQQRb7jUSz37mnsbPdvAjxA85yLVJvrAquSoYSJl3FLgW1CiUClKPejXUEXIBWue59mKKFkqcpuvVgrJU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717678252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/NpfVcLfCc80hy78O9r8pRjjcqAR3uS4nakxR+mpAL0=; b=PjYXGW8+kXHuoL/RExpom42eV7pkCO0x2mKtjhHqqUW0vzIEjNaJmR1e/xH7TNtm/qtVX2 zJ/DZYms7+3+2PXMmjqkQ9Ssga3vpBdjtRDE86jP07HsqbO2hV0DcUI1Jh1t/HnVPepsZS vSknPmMncrJ60T9cIDUlZcVny787Wds= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-Tlu9QAo3MKSuRulUXOMxJQ-1; Thu, 06 Jun 2024 08:50:51 -0400 X-MC-Unique: Tlu9QAo3MKSuRulUXOMxJQ-1 Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-5b9cc90b70aso626631eaf.0 for ; Thu, 06 Jun 2024 05:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717678250; x=1718283050; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/NpfVcLfCc80hy78O9r8pRjjcqAR3uS4nakxR+mpAL0=; b=Vo5uPte3uQhaB3xb6wJpK8Rrtjo5QxtBDSRwMVq0axUdanvwnYY7PdaMjdu0poaPGg 2lDQ/RNqoYIMAZ+5Ll+G8ANXvT13S8ty6lAS8YICpDF9rEaLadGaYozbIDJqCILxJCSr Gygo5TN+dm9OlVj7P8jmSJ9b8VpVPvgmurCMJ8I6GNDN6Uqel95oGYronpycD8jNTYen /vXOxMJUFK+tnNpH++goyliDCL+Gkdk5cXt0jvasoUr5nM1vEMtNKVKO+LgrUMYyr6qo 8ctsYomdT6bIpWZ33cuYakESHc+c/m8VixmIc3iOAm42b6lNpZzg5Q2dRwHur8UI+lZj m0YQ== X-Forwarded-Encrypted: i=1; AJvYcCXdhzC0dKrxc/BoKEsQbey4c2wBqPi0cIVdRsImVRGzpM8MV8JC2+GB3ta79gQbQMokTM8OmTFE7tIqmh8bOUqhWvGgbnoRnGtuHw== X-Gm-Message-State: AOJu0YwKp/FH019esLm8w+u5ZDznOAyJom7NqAoFJDaQ6MeXCMlxIHYa SvUIiEw49K7cCVOL4MgSoNy0aunerEvTDQXYL3UqxIwwRhAWAtL/EKvspt27dw1wLeNcUFp8dJ9 u/9rgdbFZC6hnr0Fw/6Az6GiK7ra1px6CoL+4jEvtiWcgMaSdA0Nqv99zwH4= X-Received: by 2002:a05:6358:72a:b0:19f:10da:830f with SMTP id e5c5f4694b2df-19f10da83dbmr134137655d.14.1717678250381; Thu, 06 Jun 2024 05:50:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFj1IoNwGAq20mdkdwfjE3IMylUODxel5bbQ5f5XDZ8W8BTV0RMUyShatCk1DTRaw7wjfDzng== X-Received: by 2002:a05:6358:72a:b0:19f:10da:830f with SMTP id e5c5f4694b2df-19f10da83dbmr134135055d.14.1717678249836; Thu, 06 Jun 2024 05:50:49 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f6beaa4sm5940386d6.50.2024.06.06.05.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 05:50:49 -0700 (PDT) Message-ID: <4352e37e-f194-4fe5-83fa-f1fafc598afb@redhat.com> Date: Thu, 6 Jun 2024 09:50:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH 0/3] Small step in supporting AVX instructions To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" References: <20240521202800.2865871-1-blarsen@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/6/24 05:16, Willgerodt, Felix wrote: >> -----Original Message----- >> From: Guinevere Larsen >> Sent: Dienstag, 4. Juni 2024 21:10 >> To: Guinevere Larsen ; gdb-patches@sourceware.org >> Subject: [PING][PATCH 0/3] Small step in supporting AVX instructions >> >> Ping! >> >> Since this patch is only x86 record full, if there are no comments until >> next week, I will push this change. >> >> -- >> Cheers, >> Guinevere Larsen >> She/Her/Hers >> > I didn't yet find the time to review this, nor do I really have much expertise > in VEX nor record full. I also don't really know if/when I will find the time. > But if you are confident enough I would be ok to merging this, after skimming > over it once, I didn't see much beyond what Tom already pointed out. > > > What I did is run some testing on your patches. I found this failure on two nodes > (Fedora 39 and Ubuntu 22.04, just using gcc and unix.exp and parallel testing): > > (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main > continue^M > Continuing.^M > Process record does not support VEX instruction 0x78 at address 0x7ffff7e53315.^M > Process record: inferior program stopped.^M > ^M > Program stopped.^M > 0x00007ffff7e53315 in __memset_avx2_unaligned_erms () from /lib64/libc.so.6^M > (gdb) FAIL: gdb.reverse/step-precsave.exp: run to end of main > > > Though I didn't see this when I ran it manually on a different Ubuntu 22.04 node. > There I saw this: > > (gdb) PASS: gdb.reverse/step-precsave.exp: breakpoint at end of main > continue^M > Continuing.^M > Process record does not support instruction bound.^M > Process record does not support instruction 0x62 at address 0x7ffff7f289c7.^M > Process record: failed to record execution log.^M > ^M > Program stopped.^M > 0x00007ffff7f289c7 in __memset_evex_unaligned_erms () at ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S:182^M > warning: 182 ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S: No such file or directory^M > (gdb) KFAIL: gdb.reverse/step-precsave.exp: run to end of main (PRMS: record/30807) > > I didn't have the time to investigate further. Not sure if the error messages tell you enough. Yeah, that's enough to give me a sense of what's up. These are the motivators for this series (though the second one is further in the future). GDB doesn't know how to disassemble AVX, AVX2 and AVX512 instructions, which is what leads to "process record does not support (...)". The KFAIL (second error) is with regard to AVX-512, identified by the prefix 0x62. The first one used to have a KFAIL too, but I changed the output message so now it just shows up as FAIL (used to point to https://sourceware.org/bugzilla/show_bug.cgi?id=23188). I will update the step-precsave regexp to identify the current issue and emit a KFAIL again. > I can help if you want to know more about the CPUs or libraries. > Note that the two machines where it failed, it didn't fail for master. I don't understand how it could have passed on the same machines. I'm more curious about the output when it did pass, if you still have it. Did it use a different path for memset? -- Cheers, Guinevere Larsen She/Her/Hers > > Regards, > Felix > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928