From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3035A3856DE9 for ; Sat, 23 Apr 2022 02:34:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3035A3856DE9 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4CB071E00D; Fri, 22 Apr 2022 22:34:11 -0400 (EDT) Message-ID: <435591eb-958e-08b0-b8e8-91fb4592157a@simark.ca> Date: Fri, 22 Apr 2022 22:34:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 01/36] Move "catch load" to a new file Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220118194007.2853108-1-tom@tromey.com> <20220118194007.2853108-2-tom@tromey.com> From: Simon Marchi In-Reply-To: <20220118194007.2853108-2-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2022 02:34:13 -0000 On 2022-01-18 14:39, Tom Tromey wrote: > The "catch load" code is reasonably self-contained, and so this patch > moves it out of breakpoint.c and into a new file, break-catch-load.c. > One function from breakpoint.c, print_solib_event, now has to be > exposed, but this seems pretty reasonable. This patch moves it to the > new file, to keep it near the other solib code. After this change, > breakpoint.c drops to third place in size, now after remote.c. I would personally have left print_solib_event, since it's not really something specific to the catchpoint implementation (what the new file is about). I also don't really like when functions are declared and implemented in files with different basenames (the part before the extension). Still, this LGTM either way, I think it makes sense to move the load catchpoint stuff to its own file. Simon