From: Richard Bunt <richard.bunt@arm.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Cc: nd@arm.com
Subject: Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach
Date: Fri, 29 Jun 2018 16:39:00 -0000 [thread overview]
Message-ID: <4366b54f-6413-6f50-f558-d1aa4b4fd2ec@arm.com> (raw)
In-Reply-To: <fd29a111-0106-706d-c20a-93b977c44f2d@redhat.com>
On 06/29/2018 03:51 PM, Pedro Alves wrote:
> Hi,
>
> On 06/27/2018 11:17 AM, Richard Bunt wrote:
>
>> --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> @@ -57,12 +57,12 @@ clean_restart $binfile
>>
>> gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*"
>
> Diffing test results, I noticed:
>
> PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired
> PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid"
> PASS: gdb.base/watchpoint-hw-attach.exp: detach
> PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501
> ^^^^^
>
> It's better to avoid using unstable numbers in test names. Can you
> fix this in the obvious way (make it print "attach" only)? Thanks.
>
> Thanks,
> Pedro Alves
>
Fix pushed. Sorry about this.
Many thanks,
Rich
next prev parent reply other threads:[~2018-06-29 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 10:18 Richard Bunt
2018-06-27 13:31 ` Simon Marchi
2018-06-29 14:51 ` Pedro Alves
2018-06-29 15:23 ` Richard Bunt
2018-06-29 16:39 ` Richard Bunt [this message]
2018-06-29 16:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4366b54f-6413-6f50-f558-d1aa4b4fd2ec@arm.com \
--to=richard.bunt@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).