From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44138 invoked by alias); 29 Jun 2018 16:39:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43616 invoked by uid 89); 29 Jun 2018 16:39:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR04-DB3-obe.outbound.protection.outlook.com Received: from mail-eopbgr60056.outbound.protection.outlook.com (HELO EUR04-DB3-obe.outbound.protection.outlook.com) (40.107.6.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Jun 2018 16:39:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziU3LGLGqTLG1rMDQjJlvMO2CryOz/jo7GAh1LM1Kxc=; b=iVwFTcM52v+PEPp/RNg7EX1q/ft0E7aANhlusM3Ew3tRzqM3vc4lUQ8ID6YKeVgJUEI6HFJbe691i3+09DcVDaCADY53TaR7H1yMYLtmfJjEovAqGk7KlbOHZM0DLfhwWp5FphNoD3mQinyuBcLUhUbZe5CseA+ly7oEqXqyG24= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Richard.Bunt@arm.com; Received: from [10.32.36.144] (217.140.96.140) by DB7PR08MB3193.eurprd08.prod.outlook.com (2603:10a6:5:1e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.20; Fri, 29 Jun 2018 16:39:07 +0000 Subject: Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach To: Pedro Alves , gdb-patches@sourceware.org Cc: nd@arm.com References: From: Richard Bunt Message-ID: <4366b54f-6413-6f50-f558-d1aa4b4fd2ec@arm.com> Date: Fri, 29 Jun 2018 16:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: richard.bunt@arm.com Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00724.txt.bz2 On 06/29/2018 03:51 PM, Pedro Alves wrote: > Hi, > > On 06/27/2018 11:17 AM, Richard Bunt wrote: > >> --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp >> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp >> @@ -57,12 +57,12 @@ clean_restart $binfile >> >> gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*" > > Diffing test results, I noticed: > > PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired > PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid" > PASS: gdb.base/watchpoint-hw-attach.exp: detach > PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501 > ^^^^^ > > It's better to avoid using unstable numbers in test names. Can you > fix this in the obvious way (make it print "attach" only)? Thanks. > > Thanks, > Pedro Alves > Fix pushed. Sorry about this. Many thanks, Rich