From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=jZGM=5U=gmail.com=alves.ped@sourceware.org>
Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48])
	by sourceware.org (Postfix) with ESMTPS id 715303858433
	for <gdb-patches@sourceware.org>; Mon, 23 Jan 2023 19:45:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 715303858433
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wr1-f48.google.com with SMTP id r9so11872006wrw.4
        for <gdb-patches@sourceware.org>; Mon, 23 Jan 2023 11:45:52 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:from:references:to:subject
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=uqZX2GqaJKSzcbLxJ3zl0q2E2qs30q3xMbS5+mdUhcs=;
        b=Tih/phs4PPVFDHCXQVmhV9ZJ2GJbN4oIZd5ws3wq+a1uXA9E7d57vxobaoNO7FVLU+
         Nu5O6OnIR5A3mbRSuDUqQB+g6+hoN/JaAyYbhgnj2h6pJkcqUJw38b1KA2X0iMenrO1V
         Elh2zBc/W43QqcHeC3yuhz7MZNbt1Ja37z/s70DJ+H+cQZ/pDT6rLkzOE/WBldbNNARa
         cd/So+8MfoiUeXy4Z0yhqSA00s07JKTP1UcAE8TJVhxqu3Q1PLbSkkYOsfN4EBXERR6M
         cu2jKlnyPurnifPGb37Mm1dPT1AsnRMCR2HbKJhg9AWk+YUgAwjMiGJk+fu+Lp1FNlsj
         Zs/w==
X-Gm-Message-State: AFqh2kr0g7sbJIO6CM64NzU+bDCn82+KySbJ0inFhI+lN+pI6nJiynpa
	f2le4odLKo3qvumL5IVhoZ5aIyiYMChigg==
X-Google-Smtp-Source: AMrXdXvYEKT61ym+WeDQAHTRJKChVO4VqicF6mZl8HkKmVOpFYs+EznL91tVJ/HZFPGm11mUIyA8Yg==
X-Received: by 2002:adf:eec6:0:b0:2be:57b9:f569 with SMTP id a6-20020adfeec6000000b002be57b9f569mr11311819wrp.23.1674503151218;
        Mon, 23 Jan 2023 11:45:51 -0800 (PST)
Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe])
        by smtp.gmail.com with ESMTPSA id z6-20020a5d4406000000b002a01e64f7a1sm152740wrq.88.2023.01.23.11.45.50
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Mon, 23 Jan 2023 11:45:50 -0800 (PST)
Subject: Re: [PATCH 1/8] Convert skip_altivec_tests to allow form
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20230122215558.1931803-1-tom@tromey.com>
 <20230122215558.1931803-2-tom@tromey.com>
From: Pedro Alves <pedro@palves.net>
Message-ID: <43d91f20-d1d7-9797-195a-8ed136a660f3@palves.net>
Date: Mon, 23 Jan 2023 19:45:49 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20230122215558.1931803-2-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2023-01-22 9:55 p.m., Tom Tromey wrote:
> -if {![istarget "powerpc*"] || [skip_altivec_tests]} {
> +require allow_altivec_tests
> +if {![istarget "powerpc*"]} {
>      verbose "Skipping altivec abi tests."
>      return
>  }

Something preexisting, and that can be done after your patch, but I note that it's odd
that we have to check [istarget "powerpc*"] explicitly.  I don't think there are
non-Power altivec systems?  I think the istarget check would be better moved
inside allow_altivec_tests.  All existing callers have that same istarget check, even.