From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=7wcg=34=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id 043773839D98
	for <gdb-patches@sourceware.org>; Mon, 28 Nov 2022 16:09:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 043773839D98
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [10.0.0.11] (unknown [217.28.27.60])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 71EE81E0D3;
	Mon, 28 Nov 2022 11:09:18 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1669651758; bh=EZUgQwQMS+VZohINXgvZoNV4jZTESrBQzYB0Uh7F1MQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=D4aYKmQct1OG2XI6jpqFqhjM0tQxPqckmvvM5dud4pPjAMIgF6sADukjguoGBDATK
	 fZ/ZZebaBNDSZOAC0OemSgDjaH5woxBVPBSCX7TJJxAAZU9XSi5AMPIrW4wiT3MlfP
	 q3ygq2AG75bkLFNl7zLlXJtS2Ku5MMeTeQITnCIM=
Message-ID: <44aeec44-7c18-f165-44a7-664a96c368e8@simark.ca>
Date: Mon, 28 Nov 2022 11:09:18 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 5/6] gdb/aarch64: Factor out most of the
 thread_architecture method
Content-Language: en-US
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
 gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@arm.com>
References: <20221126020452.1686509-1-thiago.bauermann@linaro.org>
 <20221126020452.1686509-6-thiago.bauermann@linaro.org>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <20221126020452.1686509-6-thiago.bauermann@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>


>  /* Implement the "supports_memory_tagging" target_ops method.  */
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 07330356fdcb..ffc128d91f60 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3486,6 +3486,41 @@ aarch64_cannot_store_register (struct gdbarch *gdbarch, int regnum)
>  	  || regnum == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base));
>  }
>  
> +/* Helper function for the "thread_architecture" target_ops method.
> +
> +   Returns a new gdbarch that is equivalent to the given gdbarch, but with SVE
> +   registers reflecting the given vq value.  */
> +
> +struct gdbarch *
> +aarch64_update_gdbarch (struct gdbarch *gdbarch, uint64_t vq)

Document this using:

/* See aarch64-tdep.h.  */

... and move the doc to the header file.

Otherwise:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon