From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 8/8] Special-case wildcard requests in ravenscar-thread.c
Date: Wed, 20 Feb 2019 19:23:00 -0000 [thread overview]
Message-ID: <44cc887e-b617-9e79-573e-9f0bf9096540@redhat.com> (raw)
In-Reply-To: <87lg2gyef7.fsf@tromey.com>
On 02/15/2019 08:39 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> The reason I'm wondering is because the patch makes me wonder about
> Pedro> a step request with no sched-lock, which is the default (*).
> Pedro> In that case, you'll have:
>
> I think the default is "replay", which is normally like "off"
Yes, replay is basically "off", except when you're replaying it behaves
like "step". What I mean is that by default when you step all threads
run unlocked.
> -- but
> there's a Fedora patch to change the default to "step"?
Yeah. On my list of patches to drop from Fedora, actually.
>
> Anyway, not super important...
>
> Pedro> So seems like after this patch the lower layer might get a request to step
> Pedro> an unknown inferior_ptid? Might not happen by luck/accident.
> Pedro> I'd suspect that you'd want to do instead:
> [...]
>
> Yes, I agree. Thanks for pointing this out. I've made this change.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-02-20 19:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 14:22 [PATCH 0/8] Clean up ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 7/8] Make the ravenscar thread target multi-target-ready Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 4/8] Fix formatting in ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 5/8] Minor C++-ification " Tom Tromey
2019-02-07 9:40 ` [PATCH 6/8] Add push_target overload Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 3/8] C++-ify ravenscar_arch_ops Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-11 18:56 ` Tom Tromey
2019-02-07 9:40 ` [PATCH 2/8] Exception safety in ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 8/8] Special-case wildcard requests " Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-09 4:41 ` Joel Brobecker
2019-02-14 13:35 ` Pedro Alves
2019-02-15 20:43 ` Tom Tromey
2019-02-15 20:39 ` Tom Tromey
2019-02-20 19:23 ` Pedro Alves [this message]
2019-02-07 14:22 ` [PATCH 1/8] Fix some typos " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44cc887e-b617-9e79-573e-9f0bf9096540@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).