From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by sourceware.org (Postfix) with ESMTPS id B94CE3858000 for ; Wed, 19 Jul 2023 13:14:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B94CE3858000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3163eb69487so524512f8f.1 for ; Wed, 19 Jul 2023 06:14:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689772464; x=1692364464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=14epbjnJ6LkerRXqRgUiEqeLzIkfLHxgirHsxHoJ/w4=; b=C8MRtnEf0ff93ZyBEUXc06dovFaRHA5RdrbF/CR52eEjXCsYxd6Rpg9wuuVCUUXOpu Sl3Ut/nc29QnJ6up5eQQ/cuyGwL2Kf9kmdVlJ1/ckGOh836X8zyPp8QVNCTwUhJwG6TC w4mo6dUftSqGmLayd5RWGX7hHs8hNlTTwb8o5hqfMcpTXhGN8BSmgJJROtXuxmSnXolA XO2YW5SEGQj6f65jdupqxRauhGw9AZdubKBtNgg+ADcyqBNucl1RmvFggy0uHM4Xk9kb 4rcZa6OnmYI4NILIzaGMfAqmd5/+8JZRRCbAzukWH3aIpa6Skh3BWFJgqf4TCarWyHG2 T0/A== X-Gm-Message-State: ABy/qLa/MzdPR5oTs0d71guyihL8tEsGH5K7Hy5txTJQ/5ucRoEUOvdF 17Blbl8LeNelgLSOGJEdcdQ= X-Google-Smtp-Source: APBJJlHrb4gDKo7eTu8phkfoKIa78T/UpOFUmghnb00NZIbNmbs45mwa0iBF4Q5HnlKTDBUimevk6A== X-Received: by 2002:a5d:6b0c:0:b0:314:9dc:4c4 with SMTP id v12-20020a5d6b0c000000b0031409dc04c4mr1836748wrw.2.1689772463924; Wed, 19 Jul 2023 06:14:23 -0700 (PDT) Received: from ?IPV6:2001:8a0:723c:ca00:3b1e:8a5a:5253:3c87? ([2001:8a0:723c:ca00:3b1e:8a5a:5253:3c87]) by smtp.gmail.com with ESMTPSA id i14-20020adfefce000000b0031434c08bb7sm5309289wrp.105.2023.07.19.06.14.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 06:14:23 -0700 (PDT) Message-ID: <44de7925-b9a7-0584-db56-da9bc7e18e7d@palves.net> Date: Wed, 19 Jul 2023 14:14:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] Fix gdb.Inferior.read_memory without execution (PR dap/30644) Content-Language: en-US To: Tom Tromey Cc: Andrew Burgess , gdb-patches@sourceware.org References: <20230714-py-inf-fixes-30615-v4-0-9189744d8547@adacore.com> <20230714-py-inf-fixes-30615-v4-6-9189744d8547@adacore.com> <878rbhi9nh.fsf@redhat.com> <87lefemphy.fsf@tromey.com> <586e6a45-988f-6fc9-2bb2-da50f0b53d74@palves.net> <87h6q2ml79.fsf@tromey.com> <48df4693-3445-fe22-92e9-f11b9120b916@palves.net> <87cz0pm8s6.fsf@tromey.com> From: Pedro Alves In-Reply-To: <87cz0pm8s6.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-07-18 18:25, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Alright, now as a proper patch, with ctor intro comment tweaked, and with new test > Pedro> added to gdb.python/py-inferior.exp. WDYT? > > Looks good to me, thank you. I pushed this with a tiny change -- since scoped_restore_current_inferior_for_memory's ctor ends up with one parameter, I made it explicit.