From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 1D21B3857C4F for ; Wed, 9 Jun 2021 18:12:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D21B3857C4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id d184so4636322wmd.0 for ; Wed, 09 Jun 2021 11:12:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qe4r94Oyp50xNE8xEsfrNCKr1BDv9JTKJc3uAiv/44w=; b=riTu8lgk69iLlaGgtcl1n/UX3bt71BLi0U/stgCEHSaaWJjMxwcIjCFvReZV8w0vMT TW3RFMIGm1itdDDfhTPF3Ui22ctmDlzgeRTrvCsxlhnYUNkGGnNccaZxGj/cvZPpEyrW DdFImd1YO4KOwdwumReyqcfaVrVt4rhVQBC8+jHCsWN/sHbuDfAjCpSCwnX/eMvboi9y ve9pVAgBV34TrPjtgUIuwmHoUGCt+2sTCHMDwpVpUeNsYeGwL4aC5R/XxkK92kgE7KVp 6y4RZFbBHmV/9uz0fvnuDu81cise2qgk0+fYjCG+l43Y0yKA0TIFg7MoEOhFUJxQDQnY 3c/A== X-Gm-Message-State: AOAM531iLN/S1aER0bqrPO4n7bogeVwZYAxF7tHZVOj5jfmm8bJv0Xu2 5XAma5w3JL1rHWo0zRaMrjjSj3Adp9qrog== X-Google-Smtp-Source: ABdhPJxHb2JgJgcMXtvBPrmLtNWwKc/ns2t8cCSG/5c51hEQl6IPD1dtlWmMvtiz41HP1TlhdtufmA== X-Received: by 2002:a05:600c:3397:: with SMTP id o23mr1150888wmp.10.1623262352238; Wed, 09 Jun 2021 11:12:32 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id z10sm538353wmb.26.2021.06.09.11.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 11:12:31 -0700 (PDT) Subject: Re: [PATCH 4/4] gnulib: import select From: Pedro Alves To: Tom Tromey , Mike Frysinger via Gdb-patches References: <20210529172510.16285-1-vapier@gentoo.org> <20210529172510.16285-4-vapier@gentoo.org> <87bl8hn3y5.fsf@tromey.com> <46d0d024-1892-3584-3523-e8f5b2997630@palves.net> Message-ID: <44f44b32-0c9e-cdf0-69fa-f79a89295c04@palves.net> Date: Wed, 9 Jun 2021 19:12:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 18:12:35 -0000 On 2021-06-09 5:52 p.m., Mike Frysinger wrote: > On 09 Jun 2021 13:27, Pedro Alves wrote: >> I've always feared that gnulib's select module would conflict with that, >> but I don't know for sure. In theory, we should be able to replace all >> that code by using gnulib's select instead, though I'm not sure gnulib >> handles some particulars like Ctrl-C interruption. > > why do you think it would conflict ? the file doesn't seem to use select() > at all, and ser-mingw is always enabled for mingw targets. seems like the > func would just be ignored. gnulib also sometimes replaces headers with their own incompatible definitions. Thanks, Pedro Alves > >> I think we can avoid some pain of someone tests the import on Windows before >> merging to master. > > it's already merged ;) > > gdb.exe links for me for i686-w64-mingw32, but i don't really have any way of > testing it runs, let alone run test suite. > -mike