From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 20EB63858D20 for ; Tue, 14 Nov 2023 15:17:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20EB63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 20EB63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699975026; cv=none; b=YstzEmJD6cdJmCEZl/hW8EK0Pn0Zxd7dbpkBxBWSEaIngWV8//tck7TVMZGRzUPJ2kn9BBJuFZy1Nu7YSeT/IDMd5NcIlUL/JlV0W54Cvw1QC5UwPLlgc8OX86jQIjzvbM/sJ6rd/JZPuqevKMvhuKyWgOFudzxh4hCTklXu0zE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699975026; c=relaxed/simple; bh=8kZXuH+e9KZfGXS3SWygenRIyoF2Ckt8GGED8EPPNcA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=txyyoteMe3BUPav4p6tXgcDEVhtDDXhRvWFJoU8GYFCu1WZ4dUeMZ1U8TCLUvP4AXxN31tkJfN/ehlWRX6dzh4ofDjPSSd11AV6MDkj7ztruVTpMaCJ9+SJD3WRbcKZCer8If2d4bNXANaHWG8XJBTI2TQnwwi2yo9ffBa8iJf0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 3AEFGvLG028589 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Nov 2023 10:17:01 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 3AEFGvLG028589 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1699975022; bh=azRXyp8SYvg8E6vpgLKWpRBgDDwn7xVjbAkmLAPOeM4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=g7qZodDFc78lQ+YIpeFe9l7l7CrLea6RpRCnJ54+sGIXzr7Fc8riYHrY6MMOtRLF9 hPQW0oWQZDlXi38wy7uXRsPHlYB4KadSqRGRWB7dgEe2bmne0NKMKN6l3/jprtj2rt NyCcq/Mznp7hZVi6H8KLPNF88Tlk85x6807iKHPI= Received: from [172.25.82.120] (unknown [12.186.190.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C2B971E091; Tue, 14 Nov 2023 10:16:56 -0500 (EST) Message-ID: <45134d7f-e820-4bca-8934-4af656a04f0f@polymtl.ca> Date: Tue, 14 Nov 2023 10:16:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/24] gdb: rename gdbarch_pseudo_register_write to gdbarch_deprecated_pseudo_register_write Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20231108051222.1275306-1-simon.marchi@polymtl.ca> <20231108051222.1275306-17-simon.marchi@polymtl.ca> <87r0ksr0t7.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87r0ksr0t7.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 14 Nov 2023 15:16:57 +0000 X-Spam-Status: No, score=-3037.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/23 07:12, Andrew Burgess wrote: >> diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h >> index c2de274ed2a9..3160aa8a9613 100644 >> --- a/gdb/gdbarch-gen.h >> +++ b/gdb/gdbarch-gen.h >> @@ -200,11 +200,18 @@ typedef struct value * (gdbarch_pseudo_register_read_value_ftype) (struct gdbarc >> extern struct value * gdbarch_pseudo_register_read_value (struct gdbarch *gdbarch, frame_info_ptr next_frame, int cookednum); >> extern void set_gdbarch_pseudo_register_read_value (struct gdbarch *gdbarch, gdbarch_pseudo_register_read_value_ftype *pseudo_register_read_value); >> >> -extern bool gdbarch_pseudo_register_write_p (struct gdbarch *gdbarch); >> +/* Write bytes to a pseudo register. >> >> -typedef void (gdbarch_pseudo_register_write_ftype) (struct gdbarch *gdbarch, struct regcache *regcache, int cookednum, const gdb_byte *buf); >> -extern void gdbarch_pseudo_register_write (struct gdbarch *gdbarch, struct regcache *regcache, int cookednum, const gdb_byte *buf); >> -extern void set_gdbarch_pseudo_register_write (struct gdbarch *gdbarch, gdbarch_pseudo_register_write_ftype *pseudo_register_write); >> + This is marked as deprecated because it gets passed a regcache for >> + implementations to write raw registers in. This doesn't work for unwound >> + frames, where the raw registers backing the pseudo registers may have been >> + saved elsewhere. */ > > Missing a space before '*/' here. > > Thanks, > Andrew Hmm, this is in gdbarch-gen.h, so this is due to how gdbarch.py does things. Simon