From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8EA413858D35 for ; Fri, 15 Sep 2023 20:19:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EA413858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38FKIBMf022958 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 16:18:16 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38FKIBMf022958 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694809096; bh=myiV7aSRm6WkejJeK60uHiUGug+nEpPVDcayCQEDYkk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Op/jt0twKmYf/6sJT4YhpCkQRa1rziBBwzRJjNM99WZTeoCv4JGuYUqccvmqYIK+3 BvdkaBMZc+A6MnOETkZf8ma1nER4NQ18mTssT2q1oWOuib6afknNzGlCwsZWLogmgo xCztg3RG69i7Z4c4s3bpAoa6gAG+jEoxSZk5HlFI= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 61C971E092; Fri, 15 Sep 2023 16:18:11 -0400 (EDT) Message-ID: <45156e33-2ea5-4003-98fd-592f762890d5@polymtl.ca> Date: Fri, 15 Sep 2023 16:18:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] gdb/testsuite: add linux target check in allow_hipcc_tests Content-Language: fr To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20230915145249.22318-1-simon.marchi@efficios.com> <20230915145249.22318-2-simon.marchi@efficios.com> <20230915171955.x5azvjkeavyydjls@octopus> From: Simon Marchi In-Reply-To: <20230915171955.x5azvjkeavyydjls@octopus> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2023 20:18:11 +0000 X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/15/23 13:19, Lancelot SIX via Gdb-patches wrote: > On Fri, Sep 15, 2023 at 10:52:12AM -0400, Simon Marchi via Gdb-patches wrote: >> ROCm / HIP tests should only run on Linux for now, existing gdb.rocm >> tests miss such a check. Add an "istarget linux" check in >> allow_hipcc_tests. >> >> Change-Id: I71f69e510a754f2fdadc32de53b923ebb9835ab5 >> --- >> gdb/testsuite/lib/rocm.exp | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp >> index 98a3b308228d..791f1b403bb7 100644 >> --- a/gdb/testsuite/lib/rocm.exp >> +++ b/gdb/testsuite/lib/rocm.exp >> @@ -67,6 +67,10 @@ gdb_caching_proc allow_hipcc_tests {} { >> return {0 "remote debugging"} >> } >> >> + if {![istarget "*-linux*"]} { >> + return {0 "target platform is not Linux"} >> + } >> + > > Hi, > > This looks good to me. > > As this is a rocm-specific part, I think I can now add: > Approved-By: Lancelot Six Indeed, thanks! Simon