From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic302-20.consmr.mail.ir2.yahoo.com (sonic302-20.consmr.mail.ir2.yahoo.com [87.248.110.83]) by sourceware.org (Postfix) with ESMTPS id 083B93858D37 for ; Tue, 21 Nov 2023 14:03:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 083B93858D37 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 083B93858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=87.248.110.83 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700575433; cv=none; b=SB11n5Mlpp39abau7JibEshdSlRMqBYFEVnTb8QbbvaOmsuJV86JrIT3vbfvYEYD96TetZjKwimVDrq8kmuMyalLwUQ+NZSn0S8aRvv73vGBiF4J8fkWO48n7jYmqyyhg8mokR9jvESr000jJGKGYWVU6wxuWHPqq5lAAubGeSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700575433; c=relaxed/simple; bh=UTXSrF6QISh2xNZie2ep5R0JjnrZazDAod6uHa3XP2g=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=EVClUNutW9JBXspF3j9MBDYKjOForTqyT1MxIHowSrPpwG7fk+2VLfgTYwtBzi8Ky+AIahNzO33JchhbW0JcsFAIHiAR97g3q3YczgphGNkU+5MKOF5bwASsukZBmabbWKVCXawMjwLqd0mSaf4VoDfjuw1gCZ2fefcSM/E6kUY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1700575429; bh=UTXSrF6QISh2xNZie2ep5R0JjnrZazDAod6uHa3XP2g=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=HqJnCIzYRhkjxMR2NDwEI5DHfYFHcHMQrFveWCsX35Iqc/c+fT4Os8m6xTaogkNZAopDo3F6otJpRTSTV+u3fy86wCBByasCyD3j67Wm/K60yt/upMidIllaOWuPD3X5GPMLspBCUm5Ii0/GmkXvZYScZAzlBACf6zXlv2kGOV4ZP7cfx/fpB6lCMhxmasggFtc4+8uJcUYVSKOcEXHn/PkLhzk1wOWwCOrbk9EM3ukJaPvwmZTn567fstEMx2yzMcxkO+LC/YOtC4X6fuQCZkH3rApYxN7e2CQVAMR3s9asdsAfG9HBiceRwKm6Q6H3NgiVVkLwhBqTAcKKGtpzew== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1700575429; bh=vDA6HqjvSsh3zjFtZjv35+y1ZH9Z4i8V0ZAzTegJsGc=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=rPbZYJ1vWDObV6HFB+KZxMEvRjneykqkoMwAKZ9PI//GUaEyjp6xefB3zdj9y3ZllnYAtJv5J0xBTSUQ8VD1ag1DP6YOL+f/NoujmIQedlKTc/0hUTxQxT/DZ6GpurzQQxFRwtXGLSAnhB4yDmQMNlIIx7aQ9l0te4a63UBfRIDult8UrBY0ZAk9sFsSveeoT09hlnHfVbl02d5TFiiJG1ZP5d2UKyZhDX86Q3DqRh7eDYwZIZkYpAUPXcC0blWJJXw0NUdEBRbdGG/xCX1mmkxXZfA3ZLmb/t9Cr+6sdZJpBznyi1p6GVrCjV14J98iEy/wbWRIQEit6Evw/31EWg== X-YMail-OSG: 7ibHR84VM1lCYXh3qmRM5oaum0SRmGREXFfDVtjDBMMSZEInEOSOwJ0XafdErme QkWajFeUNYBjNSf8puAJC0KbipJkCUM7NWzgL1VHqgSuHzWTR2lXxhK7GuK_OXoaY9HYZTcSi2Ct xf64H8ve.mv0GeNxRZBe1LXcM5JOkhhpNUmXAu0iItJ11kGPsokbIQGwm4dpxHFXfIaZjOc.J..I 77kEQSiLkDLcm_.3X7L7eUSqZOBX.CCRMmyYWfOuZhsnXVql4TnV6HYlwvkUqVIlOYFRHfwaKQiY bL1hChd1wAnCmn4ZznYDWb5m_G32knfcqpipx8Hh9YUnActApKl8ZQ9VpB2FIioP.s31pwuv9DUK bAztItFaQtvqTWt0OMOIsARCfFXE6NFRHAs6vDbgQKmKuLejOKD94gG0.H9.sfis.zX6iX3uFElu tGW4Yr51UKSOwARgQZE0b6AA.mabyPkpBbiqewjduSQFp4dKr.pZMuCmj3vFINngbiqJuL88lXf_ iMnO9TVHmmjaEascBbo3376k61U21kkO3ZhFhUshZ9OHRW86EaX7zWtD9xjugZ2yLz69LNMKtRhC vQ3dvQnGJ1HFUgKR25RN7ZkwFLPxPwbIN87AaB61IdN15k.xnZZ_xWJjk9xlPR2mIvoEDzpR2lpg AOK6Seqsfd0nsxHq.1_6sByYn5QeGSJnX5GyrnKHQF36AEKzTM94hh485uqo6fK2BRAdjY1TlMni zd_DlFWEBfdqZXpeSm01dTaZe99baWmbERFYasMDkySUDQk1cbCWLuXmyRcHAeQsVoK9cCixWJIt ywz97Tv.wsAVjLUJ8rmrwbLXudlUYimNuNkwCEcTZIpA3rCTSRjLu9EFPi2jMAKl6cAj5fmV4Wgd ZYaweNPSb9t20kScAgWR.xFWq2Quev9Lg_KT1387lOGM.0DHLU1v6haZHlqGRFssq_HoqtqyTIdu eS_TXQmAJua65ZVDs.JWpzRJRFt3eh51ANKWLBWgvniH3hi.ItzPAKUTHwPa3LKosst_eJ505t6d KQT_3ZdM7jqQuUkG1RDq8SNwGH7wdJr3eG3KumVDTsqIS2_2qctw4W4MjtmYd.4N8oEk2kDaSgwT Vw7NXdfdHHCjFKXjrDzoOOsSMt7bUz4JGsHr2S8UC8_bwy5CFdxI8tZlQtKQ2LwUQgYF45LgUu.b 6JjSNIXvb0V0o_McI3YZ10SKC3_0BCSkjZFNiN0cqBwR3h0c7hUg5YyxYOBAcbBtLmtBoNSVH92S QaUhhchV8u3hU75NpHjvmc467O5heO9QktkRrSxBivhRrjiH5bhirMCnbkjLUZbWrvmc5dPMI.5B T8jVvGJ46k9eMrdTv6.E1WHO8QsWMU7Mrqt6GWzytmIPGkbbnBO8CdAWDyXfmD2Cbhn8svuJ6mGY QLiQler6qtqUnfYz8SJW8M1Vii7FLo4T0Kqw6UHRuf6snsGYZ8AOE4wrkSxaTsGTXvgrUlFgMZoC 3a8ul8BRxETw53J7yolmmpiMPKR4tf0gnzD76sZ3TkAVb5EPjH_6kUalBpOFUm7Cdci9ERVg6nqL uj29lDWuuDjTmmjuPo7C42U.9WkcYIIUdk6C1IqyzG0o.azxnSbed9gauF4bSJ4dKbIhx2TV2OMv jM.Sl1rS_ODDwe7ex1UIGGv3AT.WTuKhRz4M4TW60yyVxAaluouAricuAlLtlJc58gisrpBEQGkw 1WoUOLMPqYuXQfidoEi.Tnv.fmHFjtAJFaED8vcKiBUF8lzH6P36wA3akCoT3KuX3gt34SbN_wMu b_huRocgPrMuk_T.LFnWpZpmjkJONZ_39yjQ2KhOKtmalRK.MCqZ6zUTOj0HC82.tyLIwn2eiSne _EtlFfwfYXCyrtBDNW_4LFcnxUXIrQNVzcfrpHwlkX7aOxT0Xe2rGHHg3r5Unj3j_ds_gDQu4JSp baaDr5V_RzYS_ZVRDcjeTWq22N40JU_FPB5yi.kKBA5fYlq13T_Cgokoqb_KXaJVqUX9GBpYqSCc 74PQGhKAcoaiCd7aLEkh6th5nAdpRR.onxMZhm2oBKkRwapRczzLHPvWBnF00.2VxECM6e_i42ZC 5aZC8DEeiYGqtaNahhsVfuZOeBIJGrEWMBzAcBbxECkZ74juYrqtW3lWi5phLQkKu47XqP_G46MA h5mSVIhUKesHPRCACGWMJ4R19gaoPZMNbFXZ0_I2lsEdCroMySn1xSXNN7UUG1pvo5LvhB.W6rrY UsBK3oQAdRtduTKNZrlIXqBu5g46a8I7w0OVYVC0- X-Sonic-MF: X-Sonic-ID: 61886415-49ed-4225-aba8-2f714690a878 Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Tue, 21 Nov 2023 14:03:49 +0000 Date: Tue, 21 Nov 2023 14:03:44 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , Guinevere Larsen Message-ID: <452419883.9918269.1700575424939@mail.yahoo.com> In-Reply-To: <69c3cefe-78ed-8d03-f1b4-acd7fee3fe1a@redhat.com> References: <20230914162732.2077-1-ssbssa.ref@yahoo.de> <20230914162732.2077-1-ssbssa@yahoo.de> <05d3b3e1-fb3c-4a1d-c5c1-75975c2af367@redhat.com> <175805758.9196163.1700495962988@mail.yahoo.com> <69c3cefe-78ed-8d03-f1b4-acd7fee3fe1a@redhat.com> Subject: Re: [PATCH v2] Fix hardware watchpoints in replay mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21896 YMailNorrin X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Dienstag, 21. November 2023 um 13:52:42 MEZ hat Guinevere Larsen Folgendes geschrieben: > On 20/11/2023 16:59, Hannes Domani wrote: > >=C2=A0 Am Montag, 20. November 2023, 14:09:34 MEZ hat Guinevere Larsen <= blarsen@redhat.com> Folgendes geschrieben: > > > >> On 14/09/2023 18:27, Hannes Domani via Gdb-patches wrote: > >>> Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 > >>> caused a regression that meant hardware watchpoint stops would not > >>> trigger in reverse execution or replay mode.=C2=A0 This was documente= d in > >>> PR breakpoints/21969. > >>> The problem is that record_check_stopped_by_breakpoint always overwri= tes > >>> record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOIN= T > >>> value which would be checked afterwards. > >>> > >>> This commit fixes that by checking if record_full_stop_reason is > >>> TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it. > >>> > >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969 > >>> --- > >> I have sent a review to this patch. Your spam filter must have catched > >> it or something similar. If you can't find it, here's the link for the > >> public inbox: > >> https://inbox.sourceware.org/gdb-patches/2eb65a2d-aa80-5930-3033-bfd82= baa2ed9@redhat.com/ > > I saw that, but it doesn't really make clear what I should do now. > > And from what I can remember of our discussion on IRC, you wanted to wa= it if Pedro had anything to add. > > > Ah right, sorry, this last month has been pretty hectic, our > conversation completely slipped my mind. All right, I'll do that. > I took a second, long look at record_check_stopped_by_breakpoint and > convinced myself, I don't see why it should overwrite the reason if gdb > is not stopped at a watchpoint. I would say send in a v3 with that > solution instead, CC Pedro, and I'll give some time for him to react > before approving the changes. > > Also, the changes you made to gdb.reverse/watch-reverse.exp should also > be made on gdb.reverse/watch-precsave.exp, since it has the same problem > that you identified with watch-reverse. We also discussed this on IRC, it doesn't work for watch-precsave.exp becau= se restored recordings are handled like corefile targets, and there hardware w= atchpoints are always disabled. But I can mention this in the commit message as well. Regards Hannes