From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 53515381FE7A for ; Tue, 28 Jun 2022 15:10:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53515381FE7A Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7EAFC1FE74 for ; Tue, 28 Jun 2022 15:10:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E4F813ACA for ; Tue, 28 Jun 2022 15:10:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ivRRGdIZu2IzbgAAMHmgww (envelope-from ) for ; Tue, 28 Jun 2022 15:10:10 +0000 Message-ID: <45414685-748a-00f4-4bd9-6a0d4d53eaa4@suse.de> Date: Tue, 28 Jun 2022 17:10:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: [committed][gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie Content-Language: en-US From: Tom de Vries To: gdb-patches@sourceware.org References: <20220622130529.GA2260@delia.com> In-Reply-To: <20220622130529.GA2260@delia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 15:10:12 -0000 On 6/22/22 15:05, Tom de Vries wrote: > Hi, > > When running test-case gdb.reverse/i387-env-reverse.exp for x86_64-linux with > target board unix/-m32/-fPIE/-pie, we run into: > ... > (gdb) PASS: gdb.reverse/i387-env-reverse.exp: push st0 > info register eax^M > eax 0x56550000 1448411136^M > (gdb) FAIL: gdb.reverse/i387-env-reverse.exp: verify eax == 0x8040000 > ... > > The problem is that the tested instruction (fstsw) only sets $ax, not $eax. > > Fix this by verifying $ax instead of $eax. > > Tested on x86_64-linux with target boards unix/-m32 and unix/-m32/-fPIE/-pie. > > Any comments? Committed. Thanks, - Tom > [gdb/testsuite] Fix gdb.reverse/i387-env-reverse.exp for -pie > > --- > gdb/testsuite/gdb.reverse/i387-env-reverse.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp > index a0a79c22ed0..53fee0986df 100644 > --- a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp > @@ -64,7 +64,7 @@ with_test_prefix "forward" { > gdb_test "n" "asm.*fstsw.*" "store status word in EAX" > gdb_test "n" "asm.*fld1.*" "push st0" > > - gdb_test "info register eax" "eax *0x8040000.*\[ \t\]+.*" "verify eax == 0x8040000" > + gdb_test "info register ax" "ax *0x0.*\[ \t\]+.*" "verify eax == 0x0" > gdb_test "info register fstat" "fstat *0.*\[ \t\]+.*" "verify fstat == 0" > gdb_test "info register ftag" "ftag *0xffff.*\[ \t\]+.*" "verify ftag == 0xffff" >