From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 49215386CE4B for ; Wed, 8 Jun 2022 14:59:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49215386CE4B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id z9so4270900wmf.3 for ; Wed, 08 Jun 2022 07:59:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=yf0T9p1k8OwDmwjM7Kwa3RdoHTLM5nzYuvD09R3pNxU=; b=mfsnwkgikhCnqABSuzszvoHr4K6iIqCv267ehn9uywT5/yydkmKLXWixnshM6jNqA/ Jv//ZAu+bhvkYcQzx8tDneKSRKgRaIsariayqeU46M2a58fTtYzGWvG2K4ByYITru4NH Ewc8an8YH97lcCMZyD1y0TSN0Qn+fgB614sMSpxv0T4HpEUe83Jachz/0gIwZIDRzKwX m4KReGrDYzFfe/r6B/67fJ3bW+koY0nDa63kr3Kmx6+fQDCvtXF6M3yFBiDYF6hkmoUY 5H5sBlzNDC6+nNCqVL92hzWc3dkGiq/kus2//MRAfehXn2+23rITuIok4Qjod102hanB H63w== X-Gm-Message-State: AOAM531f00IUWV0DFQ5DtjsTEoXwAFgrNlhQDeDHIngtwjiVWahG5CIK MeFbauN/T6VsWKy4IWKc3Dbyfefl6Oo= X-Google-Smtp-Source: ABdhPJz0SPFMHbpnW7oWHiGnrNVd2XtiJB4BYA8R6oKysMOZ2gJ0WHfZoKPqeLeH/DfKwzXOcttupg== X-Received: by 2002:a7b:cd82:0:b0:39c:5534:cd97 with SMTP id y2-20020a7bcd82000000b0039c5534cd97mr14282509wmj.134.1654700355167; Wed, 08 Jun 2022 07:59:15 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id p3-20020a05600c358300b0039c4cc65701sm11564891wmq.3.2022.06.08.07.59.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 07:59:14 -0700 (PDT) Message-ID: <45640022-a9a8-aa2d-560d-e46dc6d0ff60@palves.net> Date: Wed, 8 Jun 2022 15:59:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 01/14] gdb/testsuite: introduce gdb_step_until_regexp Content-Language: en-US To: Andrew Burgess , Bruno Larsen , gdb-patches@sourceware.org References: <20220526151041.23223-1-blarsen@redhat.com> <20220526151041.23223-2-blarsen@redhat.com> <87ilprgd7j.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87ilprgd7j.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 14:59:17 -0000 On 2022-05-27 17:19, Andrew Burgess via Gdb-patches wrote: > > I'd go with something like: > > # Single step until the pattern REGEXP is found. Step at most > # MAX_STEPS times, but stop stepping once REGEXP is found. It all sounds fine, except that "single step" usually means "stepi", while the proc uses "step". So I'd suggest "Single step" -> "Step".