From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Update the 'g' packet documentation
Date: Thu, 16 Feb 2023 17:10:38 +0000 [thread overview]
Message-ID: <459e115b-5dff-2e37-46aa-9e8e7495536a@palves.net> (raw)
In-Reply-To: <87o7qfn2qy.fsf@tromey.com>
On 2023-01-30 9:15 p.m., Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>
> Pedro> Here, the new text still uses "collected", but lost the reference to trace frames.
> Pedro> It seems to me that that will result in people not knowing what "collected"
> Pedro> means in this context.
>
>>> Yeah, I wanted to get rid of the trace frame note, because it's
>>> confusing -- 'x' can be sent any time, not just a trace frame.
>
> Pedro> Yeah, but then people won't know what "collected" here means. Also, in the normal
> Pedro> case you shouldn't really end up with unavailable registers -- if some register
> Pedro> really doesn't exist, then the target description should ideally not describe it.
>
> While I agree with that, it's also the case that tdep code can reject
> such a description, and we ran into a case like this in the wild --
> where a gdbserver does not report a register, causing i386-tdep to
> reject the description. However, at one point AdaCore had a port for
> this target, and that port reported the register but sent back 'x' --
> which worked.
Curious. It sounds like we made some register in a tdesc feature mandatory,
even after the tdesc feature existed in previous releases? That shouldn't have
happened.
>
> Also, I wanted to say, I think I misread your first reply. If I'd read
> it correctly I would have rewritten the text. I'm sorry about that.
No worries at all.
> Pedro> How about this version of the patch? It combines your original patch with
> Pedro> my suggestions, and also extends it further to describe the normal live target
> Pedro> scenario and include a remark about just not including the register in the tdesc.
> Pedro> (Note: I did not add an xref for the target description section at the end because
> Pedro> there's already one in the preceding paragraph.)
>
> This sounds great. Thank you.
Great, I'm going to merge it.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2023-02-16 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 18:37 [PATCH] " Tom Tromey
2023-01-11 19:56 ` Eli Zaretskii
2023-01-13 12:09 ` Pedro Alves
2023-01-13 18:58 ` Tom Tromey
2023-01-27 15:25 ` [PATCH v2] " Pedro Alves
2023-01-27 16:15 ` Eli Zaretskii
2023-01-30 21:15 ` Tom Tromey
2023-02-16 17:10 ` Pedro Alves [this message]
2023-02-16 18:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459e115b-5dff-2e37-46aa-9e8e7495536a@palves.net \
--to=pedro@palves.net \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).