public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/git: highlight whitespace errors source files
Date: Mon, 18 Jul 2022 11:36:13 -0400	[thread overview]
Message-ID: <45d241a7-e128-e2d7-5ba7-e4ecfa5f05c1@simark.ca> (raw)
In-Reply-To: <20220718144359.1473453-1-aburgess@redhat.com>

On 2022-07-18 10:43, Andrew Burgess via Gdb-patches wrote:
> For a long time I've had this in my ~/.gitconfig:
> 
>   [core]
>           whitespace = space-before-tab,indent-with-non-tab,trailing-space
> 
> which causes git to show me if I muck up and use spaces instead of
> tabs, or leave in trailing whitespace.  I find this really useful.
> 
> In this commit I'd like to propose adding something similar to our
> three .gitattributes files, and enable whitespace error detection for
> all .h, .c, and .cc files.
> 
> Errors are highlighted during a diff, for lines being added.

I think this is a good idea, it can only help.

Simon

  reply	other threads:[~2022-07-18 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 14:43 Andrew Burgess
2022-07-18 15:36 ` Simon Marchi [this message]
2022-07-18 18:08   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45d241a7-e128-e2d7-5ba7-e4ecfa5f05c1@simark.ca \
    --to=simark@simark.ca \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).