From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id DBA213858C62 for ; Wed, 3 Jan 2024 19:52:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBA213858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DBA213858C62 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704311534; cv=pass; b=Ik+BFMdUQtQ718LDJdlqKBedahd1qBMwHDa9E3AyRLziJsJoiQmUYhnL2N1QUM3ERAA+44Q66s8LYX4UJ9zO48u5TSo4EwKu9posUovHG/qHafRrTxKQif8syCMvwXZd/5hTj3BKe4FAihuXSONs3rc4iB12k7JQRHV4jtoe6Io= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704311534; c=relaxed/simple; bh=PiluS5Ra+EvXanSrPHZLr8SSAPTejDEEIqZAOGva+IE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XquQu0F57LS9wJRgl1iYhmCsYR0CfP3fzX+w1W/NgLZwjBqtoIIIuJu7zI57fTDpsLGbr2/tWipj4BoB7xHy9lfzM3cQYYXhb2TAJ8NKZeCzSSSPohFNMyBfu04kpUmR8G555t3zO2QC1KmiiAQzhudwppzwYcVOngaWEVoDo20= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4T50jh5tDVz3rMR; Wed, 3 Jan 2024 19:52:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T50jh575Vz4KJW; Wed, 3 Jan 2024 19:52:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704311528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKXl5qZ6lXU48NrPgitWRhEApZ2XxxlQhd3idDQAudc=; b=jc0Jn9u2K0tNQQO0iBal7TwiF2djsZfbrJvpcztpSp4T3ECZHMxT0G1jxiGKRKo7JCLcCW RGKZ1HvQTLkWHubPKr48+DIKVV3c4xvJFiAIAkZgVrG6xHMWaibu4igOs4s2sCxiqpq6ql 8jSqaYVir7QHyut5PuTx9n/GeJCwfGNJkbgzoRpu0VRKwf6bDssZCouGqn/WnpjBoKfQ7t NwJul0by8r7OHBDjqPVUd2m+WvBeKs/Y2mfwn8GIaLzlFd8HrzZ/RIozfrYreJRPmXM4ZF liZVWR3qIOqu0NVtF861y7PCFkMqcZ/X0DyfRGtTdGoZPWFZe/AsL9aUY0V3Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704311528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKXl5qZ6lXU48NrPgitWRhEApZ2XxxlQhd3idDQAudc=; b=RStUA4nVbrds3BIgOEJf79bXx8hBzY4lk7dwe/KnPr4ats7Q/kQlWvVPrB9WmiplRsgRns i3+K6x76EyBW8+nlW+gzt0/6HFOAuq3rTuyeM3DoMyQkSbBU8KdojvC9evdkgXWtbbQ/DZ cr5h9Ui52W9Mfn8TtZeQ4nhLoxNIZZDAIocXljDUrOgElsMLDC0XJtmXswV55Fzqllj6D+ mDcR6VAbhNdBVts2Wm1uqW03bXjpHidCU3BGlzzdAhMbvEflj0T1xQX8qlsDvbv7x1jSro vwZVuOex5vdSM/fdAT7n+3o0Vad2HkOjdnQsuKscYH03Y/qDCBtoJ2xHS9z+HQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704311528; a=rsa-sha256; cv=none; b=EmGog5tQ4MLqt1jWmDWTx+Ia1bss1TjDeAKDiFeggNYEUrd4YUkH7/VjZwHTU/V5/ntHQ5 jS0sFXeQsWY61JJTAQuRYM3UfazcqWTUPSpVczsWXU63a/EDfB3hBaHKIJ6VWJ80+W/x/J JMNN5TFYmjyeOE0psoPLShMaRdc8Um7SiVSs67/f5x9sd1cvdbjs2Gh9C7qTD4XjiubVJr TQ2w6NBabZOZxv1Y6jvzm/jxjixA0zN2ZTKQrC2ygcBPMwPmgcOru9WaGX2p3HTchY5+d4 xqvwN6d2sms55gH7tTDMS8f4k6VdQV1vQR+5yyyFpJwctA1zutP4TYOBDhji0w== Received: from [IPV6:2601:644:9381:f410:71db:fcca:3a29:6836] (unknown [IPv6:2601:644:9381:f410:71db:fcca:3a29:6836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T50jh2LKkz17KN; Wed, 3 Jan 2024 19:52:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <45e7649d-ac6d-47da-ac67-618cf85d2f8d@FreeBSD.org> Date: Wed, 3 Jan 2024 11:52:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 0/3] Changes to error reporting from the expression parser Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/2/24 6:43 AM, Andrew Burgess wrote: > In V2: > > - Have split the "merging of error handling" into its own patch, > adding the new error handling is in its own patch. > > - Reordered patches, the minor bug fix is now first, follow by the > refactor, with the new functionality placed in the last patch. > > - Have dropped the whole marker idea, and gone with the > simpler 'error at end of ....' style message. This means that no > tests need updating -- I have added a couple of new tests, but > everything else should continue to pass as before. > > --- > > While working on another patch I wished that the error reporting from > the expression parser was better. This series is my attempt to make > it better. > > --- > > Andrew Burgess (3): > gdb: don't try to style content in error calls > gdb: merge error handling from different expression parsers > gdb: improve error reporting from expression parser > > gdb/ada-exp.y | 2 +- > gdb/c-exp.y | 5 +---- > gdb/d-exp.y | 5 +---- > gdb/f-exp.y | 5 +---- > gdb/go-exp.y | 5 +---- > gdb/m2-exp.y | 5 +---- > gdb/p-exp.y | 5 +---- > gdb/parse.c | 15 +++++++++++++++ > gdb/parser-defs.h | 9 +++++++++ > gdb/procfs.c | 6 ++---- > gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++ > 11 files changed, 41 insertions(+), 29 deletions(-) > > > base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee Modulo the one nit I mentioned for the first patch, (and with the updated comment you noted in your reply to Lancelot SIX), these both look good to me. Approved-By: John Baldwin -- John Baldwin