From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <research_trasio@irq.a4lg.com>
Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0])
	by sourceware.org (Postfix) with ESMTPS id 4A55C3858415
	for <gdb-patches@sourceware.org>; Tue, 25 Oct 2022 17:17:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A55C3858415
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6E17B300089;
	Tue, 25 Oct 2022 17:17:12 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com;
	s=2017s01; t=1666718232;
	bh=VH0wpAfCFl9v6YsOO26zvgfFFEu/lul7LWqvM4cl1/o=;
	h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=iHTTkID3E9TpWlxMEUgBTwpg0fXgz3oCqN5R6jbmmX1s8j90nfs29SF6NV0TfMKVZ
	 iyvaee//y5YdRK8LJ8U96mW6OYA9tRnmXKavr4OC72WdP+UF9OFXCq9+tr4UszPTKy
	 ROFuRyGNsFoqr1t22XHH8On9aENAbCGIGKIFHS/E=
Message-ID: <45f95875-667a-3f63-db4c-2d135cb9bfe9@irq.a4lg.com>
Date: Wed, 26 Oct 2022 02:17:10 +0900
Mime-Version: 1.0
Subject: Re: [PATCH] sim, sim/m32c, sim/rl78: Use getopt_long
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
References: <3b7e769f-b5e9-4049-786f-d00d997f0280@irq.a4lg.com>
 <24e83e920d728237c4efe6f4720643d6fbbf1084.1666113214.git.research_trasio@irq.a4lg.com>
 <87sfjhb0r5.fsf@tromey.com>
 <2024f524-35e3-cdc6-8098-a220daf30c23@irq.a4lg.com>
 <87y1t3c08e.fsf@tromey.com>
From: Tsukasa OI <research_trasio@irq.a4lg.com>
In-Reply-To: <87y1t3c08e.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2022/10/26 1:54, Tom Tromey wrote:
>> Glibc (2.25 or before; not too old to drop support) includes <getopt.h>
>> from <unistd.h> but this causes <unistd.h> to include Binutils/GCC's
>> include/getopt.h.  It means, using the filename "getopt.h" in an include
>> path (-I) itself is a risk.  The only reason it didn't cause a problem
>> is most of Binutils/GCC components used getopt_long and
>> getopt_long_only, not plain getopt.
> 
> What exactly was the problem?
> It seems to me that we'd want to use the libiberty getopt.h, because
> we're also linking against the linking getopt.
> 
> Tom
> 

I've described it in the commit message of PATCH v2.
<https://sourceware.org/pipermail/gdb-patches/2022-October/193115.html>

If there's other questions, feel free to ask me.

Tsukasa