From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8277A3858D35 for ; Wed, 26 Jul 2023 19:37:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8277A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 36QJbebF005537 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jul 2023 15:37:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 36QJbebF005537 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1690400265; bh=14KXh6/Q84Utf6DTlh42xmFMbIm5jh+TeXJXmAubi40=; h=Date:Subject:To:References:From:In-Reply-To:From; b=YC3+fIQriRiUAaNvOnppKWt4mGp8OmfpuA4IldKAfYxdAErBPX4/yO8FcGREbubx3 Fy0B2eti8xG933fwE3mi7f9GDB3o2dL+26GGs0+/OSdIoRAWEjJkCbj+aXfhrj5Ftb 6Q/DcmETKrmHlyCnXujwAOmStICk1p+/6NJ+0iRE= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3F62A1E00F; Wed, 26 Jul 2023 15:37:40 -0400 (EDT) Message-ID: <46005ee3-1c0e-a35b-e119-ad9ec8109fc3@polymtl.ca> Date: Wed, 26 Jul 2023 15:37:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/15] core: Support fetching x86 XSAVE layout from architectures. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-4-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20230714155151.21723-4-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 26 Jul 2023 19:37:40 +0000 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/14/23 11:51, John Baldwin wrote: > Add gdbarch_core_read_x86_xsave_layout to fetch the x86 XSAVE layout > structure from a core file. > > Current OS's do not export the offsets of XSAVE state components in > core dumps, so provide an i387_set_xsave_layout helper function to set Re-reading this after a few months, I wonder if naming this function i387_guess_xsave_layout would make it a bit clearer. "set" makes it sound like it's a dumb setter (which it is not). In any case: Approved-By: Simon Marchi Simon