From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102256 invoked by alias); 13 Oct 2016 22:20:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102236 invoked by uid 89); 13 Oct 2016 22:20:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 22:19:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA67BB8916; Thu, 13 Oct 2016 22:19:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9DMJvq9015064; Thu, 13 Oct 2016 18:19:58 -0400 Subject: Re: [RFA v2 04/17] Introduce minimal_symbol_reader To: Tom Tromey , gdb-patches@sourceware.org References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-5-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <4617898c-a765-b2e5-56f1-df1a9e394d94@redhat.com> Date: Thu, 13 Oct 2016 22:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476393012-29987-5-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00413.txt.bz2 On 10/13/2016 10:09 PM, Tom Tromey wrote: > This patch introduced minimal_symbol_reader, a RAII-based class which > replaces the current make_cleanup_discard_minimal_symbols. > > 2016-09-26 Tom Tromey > > * xcoffread.c (xcoff_initial_scan): Use > minimal_symbol_reader. > * mipsread.c (mipscoff_symfile_read): Use > minimal_symbol_reader. > * minsyms.h (minimal_symbol_reader): New class. > (init_minimal_symbol_collection) > (make_cleanup_discard_minimal_symbols, install_minimal_symbols): > Don't declare. > * minsyms.c (minimal_symbol_reader): Renamed from > init_minimal_symbol_collection, turned into constructor. > (~minimal_symbol_reader): Renamed from > do_discard_minimal_symbols_cleanup, turned into destructor. > (make_cleanup_discard_minimal_symbols): Remove. > (minimal_symbol_reader::install): Rename form > install_minimal_symbols. > * mdebugread.c (elfmdebug_build_psymtabs): Use > minimal_symbol_reader. > * machoread.c (macho_symfile_read): Use > minimal_symbol_reader. > * elfread.c (elf_read_minimal_symbols): Use > minimal_symbol_reader. > * dbxread.c (dbx_symfile_read): Use minimal_symbol_reader. > * coffread.c (coff_symfile_read): Use > minimal_symbol_reader. OK. Thanks, Pedro Alves