From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C537D3858D35 for ; Mon, 29 Apr 2024 14:46:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C537D3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C537D3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714401999; cv=none; b=xcXW2kEYP9kNjWFCYHKb7PaDTOg/4oJbKhmWt7RBDjEHbjEDTvS5lm2H7UOKX80wNqnor4id4fHfTNzGGU1frwYdl8FYASEs5nhS0y7Jdvw3yWlLa6/HFrV0Am/kPeJ44vFN9sGVsiQzQ9kqyGo3FpbqGIERcYdv7Ork3Q0iLpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714401999; c=relaxed/simple; bh=ccCw48n74UwYj7BWZAHfXKkPae76rPPV+L8ZJ9pp3YU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=J/xnfju9Dpg7dBXQEQOhf50ajm7of5yBVdc7AbQc6xE0/M7qvj0I3j3ztoIBfNe5TSvuTRaKEEEgR2PrddfxxSUKt/v6BgSnxYhrC0Dl4nD3xZIoWt5rZ5GFGpNOTspk7rr4P6H//+uW8btqO15HA8Pm48BZR1P+kW8JoNfKkaM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43TEkTwe066431 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Apr 2024 10:46:33 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43TEkTwe066431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1714401994; bh=8NuJ++H+nXd1DzfndQuR/i2QnsOnWSqUckTeVx5q/Is=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=tQgxu1IsbJVqsdLGt9Max6zUjf1p++lsHmh1FcLkUGpafSVJrbre8ez0/u51J6SeT ZNATzhVnxRTYqxXw0pKJNrebn/NubL7bzg2PNqbV8k+NJLcmCygou4MIMRKf+Iw3pX 2Qw6Muixy/utn/tgzENsK/xvUo3QwkCCTSw4fZLs= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B169D1E092; Mon, 29 Apr 2024 10:46:28 -0400 (EDT) Message-ID: <462ce004-faf2-416e-a0f1-f22a1dd23de9@polymtl.ca> Date: Mon, 29 Apr 2024 10:46:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] gdb: move declarations of check_quit_flag and set_quit_flag to extension.h To: Alexandra Petlanova Hajkova Cc: gdb-patches@sourceware.org References: <20240423132517.2625632-1-simon.marchi@polymtl.ca> <20240423132517.2625632-2-simon.marchi@polymtl.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 29 Apr 2024 14:46:29 +0000 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/25/24 4:52 AM, Alexandra Petlanova Hajkova wrote: > > > On Tue, Apr 23, 2024 at 3:25 PM Simon Marchi > wrote: > > Move them out of defs.h, to extension.h, since the implementations are > in extension.c. > > Change-Id: Ie7321468bd7fecc684d70b09f72c3ee8ac75d8f4 > > > This looks like a reasonable change and also it introduce no regressions on Fedora Rawhide aarch64. Hi Alexandra, Thanks for the review. If you would like to get an acknowledgement for your time spent reviewing or testing, you can reply with a tag such as: Reviewed-By: Alexandra Petlanova Hajkova or Tested-By: Alexandra Petlanova Hajkova You can also put both if you reviewed the code and did some testing. The committer will then put these as git trailers in the commit message. See: https://sourceware.org/gdb/wiki/ContributionChecklist#Receiving_positive_reviews Simon