From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id D2DD338515CD for ; Wed, 25 May 2022 14:13:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2DD338515CD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f53.google.com with SMTP id p5-20020a1c2905000000b003970dd5404dso3452309wmp.0 for ; Wed, 25 May 2022 07:13:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YfybUWYwZHTFQ9Ce61O2PEO+VMhYVGKYT9CjVH1nL0w=; b=C5UO3JBKh5XSz+ow7bcm05+0U1rKUvkv/JPxFJ3H9HRj7ZThuOdGgqGQs/H6c3GwJh FV5nPfh1FC4lQQSjVyKSEY4qd2SqhGcfhHwLoscMmMBi+oAd9Z4c5NVF1QFQa/wrmp8n QeVsqTk4z+uq9GNtBnsc8N1YIGd6uEW87l2Y/TZD9OnxCS01W4mFdRYvZ4Ko2QFuwjtS oA+cLPnSf+tgntK9Ryh3OL1kR5SCIV8zHAtu/f4VxzN7Y1buVwkTWG48VzIsIrSzrz2h n1dr2XyN9KNMLzxBwrQxqBVdrrICXhbG1wVP7e3Px+Up5pP/O3eL+0qBhElV734dqtWZ RkRQ== X-Gm-Message-State: AOAM532WIjYI+1J8fpNnnwztyMVE6xp7fX27Q1pGY/bZt0nzKAXjgJyz U/RAEAVTx4PVCqZoMiXqzo6fidNakRc= X-Google-Smtp-Source: ABdhPJy/IyaJbmFRIMlRWyQ4FyJIIHRnv84hyX2SiS96WBy35Z1d0TQN0GDVOAekGmxTDy+Rv+UW+Q== X-Received: by 2002:a05:600c:2e54:b0:397:57df:dfb with SMTP id q20-20020a05600c2e5400b0039757df0dfbmr8274650wmf.200.1653487993835; Wed, 25 May 2022 07:13:13 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id e9-20020a05600c4e4900b003942a244f2esm1946681wmq.7.2022.05.25.07.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 07:13:12 -0700 (PDT) Message-ID: <464b6e68-8209-e210-95b4-dc7ac5e2eb4c@palves.net> Date: Wed, 25 May 2022 15:13:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] gdb/testsuite: prefer gdb_test in gdb.dwarf2/calling-convention Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220525134620.29789-1-lancelot.six@amd.com> From: Pedro Alves In-Reply-To: <20220525134620.29789-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 14:13:16 -0000 On 2022-05-25 14:46, Lancelot SIX via Gdb-patches wrote: > Since ed01945057c "Make gdb_test's question non-optional if specified", > if the question and response parameters are given to gdb_test, the > framework enforces that GDB asks the question. Before this patch, tests > needed to use gdb_test_multiple to enforce this. > > This patch updates the gdb.dwarf2/calling-convention.exp testcase to use > gdb_test to check that GDB asks a question. This replaces the more > complicated gdb_test_multiple based implementation. > > Tested on x86_64-gnu-linux. OK, thanks.