From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8500C383D830 for ; Fri, 10 Jun 2022 12:07:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8500C383D830 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-0eWiAjYFN1avv6X-IE2WQw-1; Fri, 10 Jun 2022 08:07:46 -0400 X-MC-Unique: 0eWiAjYFN1avv6X-IE2WQw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 970FF39F9CC1 for ; Fri, 10 Jun 2022 12:07:45 +0000 (UTC) Received: from [10.97.116.32] (ovpn-116-32.gru2.redhat.com [10.97.116.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE9811121330; Fri, 10 Jun 2022 12:07:44 +0000 (UTC) Message-ID: <4688c38f-2a36-8edb-f4d3-a63d740111f5@redhat.com> Date: Fri, 10 Jun 2022 09:07:42 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang To: Andrew Burgess , gdb-patches@sourceware.org References: <20220607125346.14861-1-blarsen@redhat.com> <87a6akg4u4.fsf@redhat.com> From: Bruno Larsen In-Reply-To: <87a6akg4u4.fsf@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 12:07:53 -0000 On 6/10/22 08:01, Andrew Burgess wrote: > Bruno Larsen via Gdb-patches writes: > >> Hi Jini, >> >> Great to hear that Kavitha's changes have landed on clang! I do think >> that it is still important to have xfails, however, since only new >> clangs would add the information, and GDB is tested in all manner of >> systems. >> >> I have changed the patch to assume that clang 15 has Kavitha's patches, >> and changed the clang compiler test. Does this look acceptable? >> >> [PATCH v4 03/14] gdb/testsuite: Change gdb.base/symbol-alias to xfail with old clang >> >> Clang didn't use to add alias information, even when using -gfull. This >> commit checks if the clang version being used is already providing alias >> information (15 or newer), otherwise it adds an XFAIL. > > My understanding from Jini's email was that for this test to pass we > would also need this gdb patch: > > https://sourceware.org/pipermail/gdb-patches/2022-April/188354.html > > So, if I had clang 15 right now, this test would still fail, right? Yes. My thought was that for clang < 15, it is an XFAIL, because there is nothing we can do about it, and I'd leave all other outputs the same. > > I guess you either need to hold this patch back until the above is > merged, or put this in with a generic "all clang" pattern (like you > originally had) and then assume someone will spot the KPASS and fix up > the test later. If I'm honest, I thought that patch would land before clang-15 was released. I can hold off on this until then. > > Also... > > >> --- >> gdb/testsuite/gdb.base/symbol-alias.exp | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/testsuite/gdb.base/symbol-alias.exp b/gdb/testsuite/gdb.base/symbol-alias.exp >> index 289f49bbc3f..078158dc101 100644 >> --- a/gdb/testsuite/gdb.base/symbol-alias.exp >> +++ b/gdb/testsuite/gdb.base/symbol-alias.exp >> @@ -31,6 +31,11 @@ foreach f {"func" "func_alias"} { >> } >> >> # Variables. >> -foreach v {"g_var_s" "g_var_s_alias"} { >> - gdb_test "p $v" "= {field1 = 1, field2 = 2}" >> +gdb_test "p g_var_s" "= {field1 = 1, field2 = 2}" >> + >> +# Clang didn't include alias information until version 15. >> +if {[test_compiler_info {clang-[1-9]*}] >> + || [test_compiler_info {clang-1[0-4]*}]} { > > Wouldn't clang-15 match the first of these patterns? Now that you mention it, it should, but doesn't. My guess is that TCL implicitly adds [^1-9] for the first character of '*', assuming that if you meant to have it, you'd have written [1-9]+ instead. However, I will change it to "clang-[1-9]-*" to not rely on that unexplained behavior. Cheers! Bruno Larsen > > Thannks, > Andrew > > >> + setup_xfail "clang/52664" *-*-* >> } >> +gdb_test "p g_var_s_alias" "= {field1 = 1, field2 = 2}" >> -- >> 2.31.1 >