Re: [PATCH 1/2] gdb/remote: replace use of std::pair with an actual struct

[Simon Marchi <simark@simark.ca>]

On 2025-10-11 09:34, Andrew Burgess wrote:
> Commit:
> 
>   commit 5edcbe2277db05b77ebf53f9c30b6c889a8729bc
>   Date:   Mon Jul 24 17:35:54 2023 +0100
> 
>       gdb: detect when gdbserver has no default executable set
> 
> Introduced a use of std::pair as a data structure to hold some per
> program space information within the program space registry.
> 
> It was pointed out during review of a later patch that the code would
> be easier to understand if the std::pair was replaced with a struct
> with named fields.
> 
> That is what this commit does.  Replace the std::pair with a struct,
> and update all accesses to use the named fields.
> 
> There should be no user visible changes after this commit.

Thanks, this LGTM.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

I would just like to point out that if we ever add more fields to this
structure (this the remote target needs to record per-pspace), then it
would probably make sense to rename to to "remote_per_pspace" or
something like that, since it would no longer be only used to hold
remote exec information.  But as of now, it's correct.

Simon