From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 138C43858D39 for ; Thu, 27 Jul 2023 17:33:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 138C43858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 36RHXHZa011396 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 13:33:22 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 36RHXHZa011396 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1690479202; bh=q0hHdD03RZCs/AI/rnD3atzBoMkBc+Bh1EY1jFxn/ko=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gN8ctJCF9tVMuSATfXcFar0XLkVsoKPMB5X2zV1i5wVYgkMyWxtFHK5OrSpsoeJIS zTcJvQmxy9GgHA8/KxPLroYJ2vPrU0EoGElH8aEmhVRZryjS35KarKrRT6BVkS+0Wg 99SAnHxlLcbljpscbHhcemAl18QflYaOmLmwpKHo= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 64AF01E00F; Thu, 27 Jul 2023 13:33:17 -0400 (EDT) Message-ID: <469edb6e-42a6-10a9-58ac-e77f2ac93fba@polymtl.ca> Date: Thu, 27 Jul 2023 13:33:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: remove trailing empty line in target-delegates.c Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230726191136.36864-1-simon.marchi@efficios.com> <87pm4dib96.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87pm4dib96.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 27 Jul 2023 17:33:17 +0000 X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-07-27 12:12, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> In a review [1], I pointed out that applying the patch, git would say: > Simon> .git/rebase-apply/patch:147: new blank line at EOF. > > Simon> However, since the empty line is in target-delegates.c (a generated > Simon> file), there's nothing the author can do about it. To avoid this > Simon> comment coming up again in the future, change make-target-delegates.py > Simon> to avoid the trailing empty line. Do this by making it output empty > Simon> lines before each entity, not after. > > Simon> Since this needs removing a newline output in gdbcopyright, adjust > Simon> ada-unicode.py and gdbarch.py to avoid changes in the files they > Simon> generate. > > Seems totally fine to me, thank you. > > Approved-By: Tom Tromey > > > Tom Thanks, pushed. Simon