From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D46C03870840 for ; Tue, 12 May 2020 17:37:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D46C03870840 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 59FCC1ED39; Tue, 12 May 2020 13:37:55 -0400 (EDT) Subject: Re: [PATCH 3/4] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars To: Michael Weghorn , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200429111638.1327262-5-m.weghorn@posteo.de> <17f345c8-eb7f-a3bb-c133-98533c7fa1c5@simark.ca> <5547e258-2f59-61a8-30e4-807a1758008c@posteo.de> From: Simon Marchi Message-ID: <46d849fa-2386-d381-d16a-5de4a77c5b26@simark.ca> Date: Tue, 12 May 2020 13:37:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <5547e258-2f59-61a8-30e4-807a1758008c@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 17:37:57 -0000 On 2020-05-12 12:07 p.m., Michael Weghorn via Gdb-patches wrote: >> If you are game, you could make another preparatory patch (anywhere in the series >> before this one) that would make construct_inferior_arguments take a >> gdb::array_view parameter. That would allow you to call it more simply >> here: >> >> construct_inferior_arguments (program_args); > > > I tried this, but as far as I understand (but I might have missed > something), this does not work here, since the gdb::array_view > constructor does not accept a const container (or reference to one) as a > parameter, so e.g. > > const std::vector vec; > gdb::array_view view(vec); > > does not work/compile, and program_args is a const reference here. > (Using a non-const vector does, but I'd personally rather not remove the > const qualifier for the 'program_args' parameter of the > 'create_inferior' method.) > > Michael Hmm yeah not sure about that. We can deal with this after. Simon