From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3FC29385840F for ; Sun, 20 Feb 2022 01:41:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FC29385840F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21K1fb3a000662 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Feb 2022 20:41:41 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21K1fb3a000662 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2DD341EE1A; Sat, 19 Feb 2022 20:41:37 -0500 (EST) Message-ID: <46f0e775-0904-092d-93dd-df263fbd28d7@polymtl.ca> Date: Sat, 19 Feb 2022 20:41:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] gdb/testsuite/README: update default value of INTERNAL_GDBFLAGS Content-Language: en-US To: Philippe Blain , gdb-patches@sourceware.org References: <20220219234029.28070-1-levraiphilippeblain@gmail.com> From: Simon Marchi In-Reply-To: <20220219234029.28070-1-levraiphilippeblain@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 20 Feb 2022 01:41:37 +0000 X-Spam-Status: No, score=-3039.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Feb 2022 01:41:46 -0000 On 2022-02-19 18:40, Philippe Blain via Gdb-patches wrote: > The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013 > ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to > disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07) > to point to the data directory, but its default value mentioned in the > testsuite's README was not kept up to date. > > Update the README accordingly, and mention where the default value is > set, so that it's easier for futur new contributors to check if the > default mentioned in the README is still current. > --- > > Notes: > I noticed that while testing the fix for PR 24069, since I wanted > to use my '~/.gdbinit' with 'set startup-with-shell off' for all tests, > and found out that setting INTERNAL_GDBFLAGS to only '-nw' made some things > a little worse (as GDB was then missing '-data-directory'). > > Meta note: when I sent this patch earlier (and messed-up my CCs) in [1], I was > confused by the fact that my CCs for Simon, Doug Evans and Tom de Vries were > not showing up on public-inbox, even in the "raw" view [2]. After a little > web search I think this is due to them setting the mailman "avoid duplicates" > setting [3]. > > [1] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphilippeblain@gmail.com/T/#u > [2] https://pi.simark.ca/gdb-patches/20220219212442.18136-1-levraiphilippeblain@gmail.com/raw > [3] https://wiki.list.org/DOC/Mailman%202.1%20Members%20Manual#A7.2_How_can_I_avoid_getting_duplicate_messages.3F_.28duplicates_option.29 > > gdb/testsuite/README | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/README b/gdb/testsuite/README > index 7552774c78b..2d3f1c45966 100644 > --- a/gdb/testsuite/README > +++ b/gdb/testsuite/README > @@ -168,11 +168,14 @@ INTERNAL_GDBFLAGS > > Command line options passed to all GDB invocations. > > -The default is "-nw -nx". > +The default is set in lib/gdb.exp and is currently > +"-nw -nx -data-directory /path/to/build/directory/gdb/data-directory -iex 'set height 0' -iex 'set width 0'". > > `-nw' disables any of the windowed interfaces. > `-nx' disables ~/.gdbinit, so that it doesn't interfere with > the tests. > +`-data-directory` points the the data directory in the build directory > +`-iex 'set {height,width} 0'` disables pagination I think this should just say "see the default in lib/gdb.exp", and the flags can be explained there. That would avoid things getting out of sync. Still, your patch makes things better than they are now, so I think we can push it in any case. Simon