From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79669 invoked by alias); 9 Nov 2018 12:59:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79650 invoked by uid 89); 9 Nov 2018 12:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Nov 2018 12:59:12 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9100E3091D5D; Fri, 9 Nov 2018 12:59:11 +0000 (UTC) Received: from [10.36.117.88] (ovpn-117-88.ams2.redhat.com [10.36.117.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D962310002B9; Fri, 9 Nov 2018 12:59:10 +0000 (UTC) Subject: Re: Small typo in iconv.m4 To: Hafiz Abid Qadeer , "gdb-patches@sourceware.org" , binutils@sourceware.org References: <1a59139c-804c-2cc5-821b-edabd3ba9f84@mentor.com> From: Nick Clifton Openpgp: preference=signencrypt Message-ID: <471f1420-6f3b-0146-02aa-61f7b99c330b@redhat.com> Date: Fri, 09 Nov 2018 12:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1a59139c-804c-2cc5-821b-edabd3ba9f84@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00145.txt.bz2 Hi Hafiz, > Hi All, > Attached config/ patch was approved and committed in gcc repo. Ok to > commit it in the binutils-gdb repo? > > 2018-11-09 Hafiz Abid Qadeer > > * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. > Append $INCICONV to it. > * gdb/configure: Regenerate. > * binutils/configure: Likewise. > * intl/configure: Likewise. Approved, please apply. I should note however that the changelog entry probably should be split up and added to the respective subdirectories ChangeLog files. In particular I was confused because I could not find a mention on the change in gcc's config/ChangeLog file, and was rather surprised when I found it in the top level ChangeLog file instead. Cheers Nick