[PATCH][gdb] Fix 'not in executable format' error message

[PATCH][gdb] Fix 'not in executable format' error message

[tdevries]

[-- Attachment #1: Type: text/plain, Size: 30 bytes --]

Any comments?

Thanks,
- Tom


[-- Attachment #2: 0001-gdb-Fix-not-in-executable-format-error-message.patch --]
[-- Type: text/plain, Size: 3076 bytes --]

[gdb] Fix 'not in executable format' error message

With trying to load a non-executable file into gdb, we run into:
...
$ gdb -q -batch test.c
"0x7ffc87bfc8d0s": not in executable format: \
  file format not recognized
...

The problem is caused by using %ps in combination with the error function
(note that confusingly, it does work in combination with the warning
function).

Fix this by using plain "%s" instead.

Tested on x86_64-linux.

---
 gdb/exec.c                                |  8 +++-----
 gdb/testsuite/gdb.base/non-executable.exp | 32 +++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 5 deletions(-)

diff --git a/gdb/exec.c b/gdb/exec.c
index 6f936c9403f..1be51474b4a 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -453,9 +453,8 @@ exec_file_attach (const char *filename, int from_tty)
 
       if (!current_program_space->exec_bfd ())
 	{
-	  error (_("\"%ps\": could not open as an executable file: %s."),
-		 styled_string (file_name_style.style (), scratch_pathname),
-		 bfd_errmsg (bfd_get_error ()));
+	  error (_("\"%s\": could not open as an executable file: %s."),
+		 scratch_pathname, bfd_errmsg (bfd_get_error ()));
 	}
 
       /* gdb_realpath_keepfile resolves symlinks on the local
@@ -475,8 +474,7 @@ exec_file_attach (const char *filename, int from_tty)
 	  /* Make sure to close exec_bfd, or else "run" might try to use
 	     it.  */
 	  current_program_space->exec_close ();
-	  error (_("\"%ps\": not in executable format: %s"),
-		 styled_string (file_name_style.style (), scratch_pathname),
+	  error (_("\"%s\": not in executable format: %s"), scratch_pathname,
 		 gdb_bfd_errmsg (bfd_get_error (), matching).c_str ());
 	}
 
diff --git a/gdb/testsuite/gdb.base/non-executable.exp b/gdb/testsuite/gdb.base/non-executable.exp
new file mode 100644
index 00000000000..4ae123a2cb2
--- /dev/null
+++ b/gdb/testsuite/gdb.base/non-executable.exp
@@ -0,0 +1,32 @@
+# Copyright 2021 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Check that loading an existing but non-executable file
+# results in the correct error message.
+
+set binfile "$srcdir/$subdir/$gdb_test_file_name.exp"
+
+clean_restart
+
+set re \
+    [list \
+	 "\"[string_to_regexp $binfile]\"" \
+	 "not in executable format" \
+	 "file format not recognized"]
+set re [join $re ": "]
+
+# Using gdb_load will generate a dejagnu ERROR, so use
+# plain file command instead.
+gdb_test "file $binfile" $re "error message"

Re: [PATCH][gdb] Fix 'not in executable format' error message

[Philippe Waroquiers]

On Wed, 2021-08-18 at 07:14 +0000, tdevries via Gdb-patches wrote:
> Any comments?
Patch looks fine for me.
Thanks
Philippe

Re: [PATCH][gdb] Fix 'not in executable format' error message

[Andreas Schwab]

On Aug 18 2021, tdevries via Gdb-patches wrote:

> The problem is caused by using %ps in combination with the error function

Why does it not support it?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [PATCH][gdb] Fix 'not in executable format' error message

[tdevries]

On 2021-08-18 08:50, Andreas Schwab wrote:
> On Aug 18 2021, tdevries via Gdb-patches wrote:
> 
>> The problem is caused by using %ps in combination with the error 
>> function
> 
> Why does it not support it?
> 

Because it hasn't been implemented.  There's a discussion about 
implementing this in the corresponding PR ( 
https://sourceware.org/bugzilla/show_bug.cgi?id=26880 ).

Thanks,
- Tom

> Andreas.