Re: [PUSHED OBV] Fix loongarch_iterate_over_regset_sections for non-native targets.

[John Baldwin <jhb@FreeBSD.org>]

On 5/24/22 2:20 AM, Tiezhu Yang wrote:
> 
> 
> On 05/24/2022 02:15 AM, John Baldwin wrote:
>> Define a constant for the number of registers stored in a register set
>> and use this with register_size to compute the size of the
>> general-purpose register set in core dumps.
>>
>> This also fixes the build on hosts such as FreeBSD that do not define
>> an elf_gregset_t type.
> 
> Hi John,
> 
> Sorry for the related issues on FreeBSD,
> the original patch is only tested on LoongArch Linux,
> thank you very much for your test and fix.

Testing on x86-64 Linux or the like might also be good to help ensure
that you can cross-debug core dumps in the future.  Testing on that
would probably have also not worked due to elf_gregset_t being different
sizes for different architectures.

>> ---
>>   gdb/loongarch-linux-tdep.c | 14 ++++++++++++--
>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/loongarch-linux-tdep.c b/gdb/loongarch-linux-tdep.c
>> index f13756dd003..bbb43abe13f 100644
>> --- a/gdb/loongarch-linux-tdep.c
>> +++ b/gdb/loongarch-linux-tdep.c
>> @@ -29,6 +29,11 @@
>>   #include "trad-frame.h"
>>   #include "tramp-frame.h"
>>
>> +/* The general-purpose regset consists of 32 R registers, plus PC,
>> +   and BADV registers.  */
>> +
>> +#define LOONGARCH_LINUX_NUM_GREGSET	(34)
> 
> LOONGARCH_LINUX_NUM_GREGSET should be defined as 45 (32 + 1 + 1 + 11)
> due to reserved 11 for extension in glibc, otherwise when execute:

Thanks for fixing the constant.  I just guessed based on what the regset
functions supplied and collected.

-- 
John Baldwin