From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2 5/8] gdb: add gdbarch_up
Date: Thu, 5 Jan 2023 19:48:16 -0500 [thread overview]
Message-ID: <47d50dda-6fe7-d366-bba3-7f514e34dfb5@polymtl.ca> (raw)
In-Reply-To: <87tu14btor.fsf@tromey.com>
On 1/5/23 15:41, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> On 1/5/23 15:31, Tom Tromey wrote:
>>>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>>
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> Add a gdbarch_up unique pointer type, that calls gdbarch_free on
> Simon> deletion. This is used in the ROCm support patch at the end of this
> Simon> series.
>>>
>>> gdbarch_free is just a wrapper around delete.
>>> What if this typedef just used the default deleter instead?
>>> Moving gdbarch to just use new/delete always looks pretty easy.
>>>
>>> Tom
>
> Simon> I think it would involve moving the struct gdbarch definition from gdbarch.c
> Simon> to gdbarch-gen.h, right?
>
> Ugh, yeah, never mind. It would be nice, maybe, to convert all this so
> the accessors are inlined and whatnot, but it's a much bigger job.
I think it would be nice to C++-ify a bit (while keeping the same
principle used today. Make all the function pointer fields private, and
change all the gdbarch_* free functions to be methods instead. So a
call like this:
gdbarch_do_something (arch, 1, "hello");
would become
arch->do_something (1, "hello");
... which would still go through the function pointer underneath.
Simon
next prev parent reply other threads:[~2023-01-06 0:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 20:02 [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-01-05 20:02 ` [PATCH v2 1/8] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2023-01-05 20:02 ` [PATCH v2 2/8] gdb: make install_breakpoint return a non-owning reference Simon Marchi
2023-01-05 20:02 ` [PATCH v2 3/8] gdbsupport: add type definitions for pid, lwp and tid Simon Marchi
2023-01-05 20:02 ` [PATCH v2 4/8] gdb: add inferior_pre_detach observable Simon Marchi
2023-01-05 20:02 ` [PATCH v2 5/8] gdb: add gdbarch_up Simon Marchi
2023-01-05 20:31 ` Tom Tromey
2023-01-05 20:36 ` Simon Marchi
2023-01-05 20:41 ` Tom Tromey
2023-01-06 0:48 ` Simon Marchi [this message]
2023-01-05 20:02 ` [PATCH v2 6/8] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2023-01-05 20:02 ` [PATCH v2 7/8] gdb: make gdb_printing_disassembler::stream public Simon Marchi
2023-01-05 20:02 ` [PATCH v2 8/8] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2023-01-05 20:17 ` Simon Marchi
2023-01-25 17:03 ` [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-02-02 15:08 ` Simon Marchi
2023-02-06 11:47 ` Tom de Vries
2023-02-06 14:01 ` Lancelot Six
2023-02-06 16:53 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d50dda-6fe7-d366-bba3-7f514e34dfb5@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).