Re: [PATCH] Remove alloca from osabi.c

[John Baldwin <jhb@FreeBSD.org>]

On 8/14/23 9:48 AM, Tom Tromey wrote:
> I noticed that the call to alloca in osabi.c can be replaced with a
> statically-sized buffer, because some code just before the declaration
> ensures that the length is bounded.
> ---
>   gdb/osabi.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/gdb/osabi.c b/gdb/osabi.c
> index d18802ac3a4..ad3dad5b849 100644
> --- a/gdb/osabi.c
> +++ b/gdb/osabi.c
> @@ -463,7 +463,6 @@ generic_elf_osabi_sniff_abi_tag_sections (bfd *abfd, asection *sect,
>   {
>     const char *name;
>     unsigned int sectsize;
> -  char *note;
>   
>     name = bfd_section_name (sect);
>     sectsize = bfd_section_size (sect);
> @@ -477,7 +476,7 @@ generic_elf_osabi_sniff_abi_tag_sections (bfd *abfd, asection *sect,
>        compressed section.  But, since note sections are not compressed,
>        deferring the reading until we recognize the section avoids any
>        error.  */
> -  note = (char *) alloca (sectsize);
> +  char note[MAX_NOTESZ];
>   
>     /* .note.ABI-tag notes, used by GNU/Linux and FreeBSD.  */
>     if (strcmp (name, ".note.ABI-tag") == 0)

Reviewed-by: John Baldwin <jhb@FreeBSD.org>

-- 
John Baldwin